From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C527C25B74 for ; Mon, 27 May 2024 15:44:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBcW4-0006jT-PM; Mon, 27 May 2024 11:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBcW2-0006ix-Vs for qemu-devel@nongnu.org; Mon, 27 May 2024 11:44:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBcW1-0004xM-Fm for qemu-devel@nongnu.org; Mon, 27 May 2024 11:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716824640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EcFh+qKyX5x8Cg0Smw3ip1Rj4U1bYuvi9Asr+c4RhMo=; b=YgvWSHskyaexvnc2U1cq0OffA6QPyProOIC/sFAZExlfIJJEgJ88UMjOn77o3rXhd3qJn7 F8gYx0z0r73wmNMObwqMm3Zd2D2WGSwfBJTExijOknHB4Hn/BQJr4YLxt4BTJIcJE3++al J0WuzeX6DMsVqSBR+L5XVQPEYbW7Wqk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-440-bdiMYSvFNaSJBP5nFUnwvw-1; Mon, 27 May 2024 11:43:59 -0400 X-MC-Unique: bdiMYSvFNaSJBP5nFUnwvw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EB5888008A4 for ; Mon, 27 May 2024 15:43:58 +0000 (UTC) Received: from localhost (unknown [10.22.8.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 467E81C008BB; Mon, 27 May 2024 15:43:57 +0000 (UTC) From: Cornelia Huck To: Thomas Huth , "Michael S. Tsirkin" , Paolo Bonzini , qemu-devel@nongnu.org Subject: Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween In-Reply-To: Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <20240527060243.12647-1-thuth@redhat.com> <871q5npa89.fsf@redhat.com> User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Date: Mon, 27 May 2024 17:43:56 +0200 Message-ID: <87y17vnttv.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, May 27 2024, Thomas Huth wrote: > On 27/05/2024 17.04, Cornelia Huck wrote: >> On Mon, May 27 2024, Thomas Huth wrote: >> >>> We are reusing the same temporary directory for installing the headers >>> of all targets, so there could be stale files here when switching from >>> one target to another. Make sure to delete the folder before installing >>> a new set of target headers into it. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> scripts/update-linux-headers.sh | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh >>> index 8963c39189..fbf7e119bc 100755 >>> --- a/scripts/update-linux-headers.sh >>> +++ b/scripts/update-linux-headers.sh >>> @@ -112,6 +112,7 @@ for arch in $ARCHLIST; do >>> arch_var=ARCH >>> fi >>> >>> + rm -rf "$hdrdir" >>> make -C "$linux" O="$blddir" INSTALL_HDR_PATH="$hdrdir" $arch_var=$arch headers_install >>> >>> rm -rf "$output/linux-headers/asm-$arch" >> >> Hm. I presume that headers-install gives us the same set of headers >> outside include/asm for every arch? > > I just double-checked and yes, apart from a file called "a.out.h", the other > headers outside of the asm subfolder are the same. So AFAICS there is still > a slight chance that we might pick up a wrong file from the asm folder... > shall I change the patch to only delete that subfolder? Or is that chance > just too small that we can ignore it? The asm folder is probably fine, but there's a chance for errors; if moving from "use union of files for all archs outside asm" to "use files for the last arch in the list outside asm" always results in the same set of files, your patch is probably the better choice here. Acked-by: Cornelia Huck