From: Jani Nikula <jani.nikula@intel.com>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>
Subject: Re: [PATCH] Revert "drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue"
Date: Mon, 11 Mar 2024 17:52:59 +0200 [thread overview]
Message-ID: <87y1aosr38.fsf@intel.com> (raw)
In-Reply-To: <Ze8k2Mbmw4IaGgv8@e110455-lin.cambridge.arm.com>
On Mon, 11 Mar 2024, Liviu Dudau <liviu.dudau@arm.com> wrote:
> On Mon, Mar 11, 2024 at 04:49:30PM +0200, Jani Nikula wrote:
>> On Mon, 11 Mar 2024, Liviu Dudau <liviu.dudau@arm.com> wrote:
>> > So with this revert we're OK with an undefined symbol if !CONFIG_PM, but we're not happy
>> > with a recursive dependency that is only triggered for COMPILE_TEST? I would've thought
>> > IOMMU_SUPPORT options is a better one.
>>
>> It's a real config.
>>
>> # CONFIG_COMPILE_TEST is not set
>
> So I can select CONFIG_ARM64 and CONFIG_X86_LOCAL_APIC at the same time? DRM_PANTHOR depends on ARM || ARM64
> and X86_LOCAL_APIC depends on X86_64. At some moment the recursive dependency detector should've stopped as
> there are no common dependencies between DRM_PANTHOR and X86_LOCAL_APIC and going further just triggers false
> positives. I'm curious how you've created your config now.
The thing is, I don't have *any* of the dependencies ARM || ARM64 ||
COMPILE_TEST set in the config that triggered this. I don't have
DRM_PANTHOR set. But make olddefconfig detects a circular dependency
nonetheless.
It's possible the issue is in kconfig. I don't know. But not being able
to even dodge the warning makes it a show stopper. I wouldn't even know
what to change in the config.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-03-11 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 11:16 [PATCH] Revert "drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue" Jani Nikula
2024-03-11 11:48 ` Boris Brezillon
2024-03-11 11:51 ` Jani Nikula
2024-03-11 11:54 ` Boris Brezillon
2024-03-11 12:26 ` Jani Nikula
2024-03-11 14:41 ` Liviu Dudau
2024-03-11 14:49 ` Jani Nikula
2024-03-11 15:35 ` Liviu Dudau
2024-03-11 15:52 ` Jani Nikula [this message]
2024-03-11 16:17 ` Liviu Dudau
2024-03-11 14:58 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1aosr38.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=liviu.dudau@arm.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.