From: Kalle Valo <kvalo@kernel.org>
To: Martin Kaistra <martin.kaistra@linutronix.de>
Cc: linux-wireless@vger.kernel.org,
Jes Sorensen <Jes.Sorensen@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] wifi: rtl8xxxu: add missing number of sec cam entries for all variants
Date: Tue, 16 Jan 2024 13:13:42 +0200 [thread overview]
Message-ID: <87y1cpfs49.fsf@kernel.org> (raw)
In-Reply-To: <20240116095001.399500-1-martin.kaistra@linutronix.de> (Martin Kaistra's message of "Tue, 16 Jan 2024 10:50:01 +0100")
Martin Kaistra <martin.kaistra@linutronix.de> writes:
> Commit b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP
> mode") introduced max_sec_cam_num as a member of rtl8xxxu_fileops.
> It was missed to set this number for all variants except 8188f, which
> caused rtl8xxxu_get_free_sec_cam() to always return 0.
>
> Fix it by adding the numbers for all variants. The values are taken from
> the vendor drivers and rtlwifi.
Does this fix a user visible regression? It would be good to add that to
the commit message. I can do it, just let me know what to add.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-01-16 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 9:50 [PATCH] wifi: rtl8xxxu: add missing number of sec cam entries for all variants Martin Kaistra
2024-01-16 11:13 ` Kalle Valo [this message]
2024-01-16 11:28 ` Martin Kaistra
2024-01-16 11:49 ` Ping-Ke Shih
2024-01-16 13:46 ` Zenm Chen
2024-01-19 17:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1cpfs49.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Jes.Sorensen@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.kaistra@linutronix.de \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.