From: Kurt Kanzenbach <kurt@linutronix.de>
To: Suman Ghosh <sumang@marvell.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user
Date: Wed, 06 Dec 2023 08:45:28 +0100 [thread overview]
Message-ID: <87y1e7g4fb.fsf@kurt> (raw)
In-Reply-To: <SJ0PR18MB5216C33138C7067A24BD4DE4DB81A@SJ0PR18MB5216.namprd18.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
> [Suman] It is up to you. But I feel, in that case we should have some
> checks to reject the ntuple rule if user is providing some valid mask
> value.
Sure. That's another issue and deserves a separate patch.
> Otherwise, there will be mismatch between user expectation and
> driver functionality.
Yeah, it's the whole point of series to improve the user experience.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2023-12-06 7:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 7:50 [Intel-wired-lan] [PATCH iwl-net v2 0/2] igc: ethtool: Check VLAN TCI mask Kurt Kanzenbach
2023-12-01 7:50 ` Kurt Kanzenbach
2023-12-01 7:50 ` [Intel-wired-lan] [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user Kurt Kanzenbach
2023-12-01 7:50 ` Kurt Kanzenbach
2023-12-01 9:55 ` [Intel-wired-lan] [EXT] " Suman Ghosh
2023-12-01 9:55 ` Suman Ghosh
2023-12-01 13:31 ` [Intel-wired-lan] " Kurt Kanzenbach
2023-12-01 13:31 ` Kurt Kanzenbach
2023-12-01 16:16 ` Suman Ghosh
2023-12-06 7:45 ` Kurt Kanzenbach [this message]
2023-12-10 11:51 ` [Intel-wired-lan] " Simon Horman
2023-12-10 11:51 ` Simon Horman
2023-12-25 9:47 ` [Intel-wired-lan] " naamax.meir
2023-12-25 9:47 ` naamax.meir
2023-12-01 7:50 ` [Intel-wired-lan] [PATCH iwl-net v2 2/2] igc: Check VLAN TCI mask Kurt Kanzenbach
2023-12-01 7:50 ` Kurt Kanzenbach
2023-12-10 11:51 ` [Intel-wired-lan] " Simon Horman
2023-12-10 11:51 ` Simon Horman
2023-12-26 10:49 ` [Intel-wired-lan] " naamax.meir
2023-12-26 10:49 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1e7g4fb.fsf@kurt \
--to=kurt@linutronix.de \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sumang@marvell.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.