From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5190C61D9C for ; Wed, 22 Nov 2023 09:15:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB77210E2FA; Wed, 22 Nov 2023 09:15:17 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29F4010E2FA; Wed, 22 Nov 2023 09:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700644516; x=1732180516; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=RrwEo1VDHhlnf+Pa2Ly1JESTxjciztMmCHm/k/NWo+I=; b=IbgB0IA+OjpO7khSMZaQJJnqrot6Z6k+5g1OW5jRhirNsFkqIDTlWe7W 7Bj9bUiI2ALucXokNkeMY7upyGhBvOxOzFw+Rcaugl+KOU4P/bY0/Y+vT huZEaWXuIE9LNKgWU+OQb9fzpfXQ7PJ+h1l1FFktG15UoQARLkVV6gzph 1TYBxuC0W+zFfnEfYaSuvqGr46yBVRVJ8lwBaa19hxOhS0yQmFxLBsAUx nFlfxbtYH/9GG+tl7D8kJfvisWkGCDiUO6TJJ7qBQ89Ih4LrLdrwI0+0W SqtuyuwDC96hr0KZdqmaPeCymeYSel+ImU9txQN5L2t0w8FjlD01hGjmZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="5158991" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="5158991" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 01:15:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="1098335938" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="1098335938" Received: from tjquresh-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.76]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 01:14:59 -0800 From: Jani Nikula To: Jiapeng Chong In-Reply-To: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> Date: Wed, 22 Nov 2023 11:14:57 +0200 Message-ID: <87y1eqm9ny.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix unsigned expression compared with zero X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiapeng Chong , intel-gfx@lists.freedesktop.org, Abaci Robot , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, rodrigo.vivi@intel.com, airlied@gmail.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 22 Nov 2023, Jiapeng Chong wrote: > The entry_setup_frames is defined as u8 type, else(entry_setup_frames < 0) > is invalid. At the same time, the return value of function > intel_psr_entry_setup_frames is also of type int. so modified > its type to int. > > ./drivers/gpu/drm/i915/display/intel_psr.c:1336:5-23: WARNING: Unsigned expression compared with zero: entry_setup_frames >= 0. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7610 > Signed-off-by: Jiapeng Chong There's already a patch. Mika, please follow up with it. https://patchwork.freedesktop.org/patch/msgid/20231116090512.480373-1-mika.kahola@intel.com > --- > drivers/gpu/drm/i915/display/intel_psr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index 8d180132a74b..204da50e3f28 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp *intel_dp, > { > struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); > const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; > - u8 entry_setup_frames; > + int entry_setup_frames; > > /* > * Current PSR panels don't work reliably with VRR enabled -- Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B846C61D9C for ; Wed, 22 Nov 2023 09:15:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 461A910E5EA; Wed, 22 Nov 2023 09:15:18 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29F4010E2FA; Wed, 22 Nov 2023 09:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700644516; x=1732180516; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=RrwEo1VDHhlnf+Pa2Ly1JESTxjciztMmCHm/k/NWo+I=; b=IbgB0IA+OjpO7khSMZaQJJnqrot6Z6k+5g1OW5jRhirNsFkqIDTlWe7W 7Bj9bUiI2ALucXokNkeMY7upyGhBvOxOzFw+Rcaugl+KOU4P/bY0/Y+vT huZEaWXuIE9LNKgWU+OQb9fzpfXQ7PJ+h1l1FFktG15UoQARLkVV6gzph 1TYBxuC0W+zFfnEfYaSuvqGr46yBVRVJ8lwBaa19hxOhS0yQmFxLBsAUx nFlfxbtYH/9GG+tl7D8kJfvisWkGCDiUO6TJJ7qBQ89Ih4LrLdrwI0+0W SqtuyuwDC96hr0KZdqmaPeCymeYSel+ImU9txQN5L2t0w8FjlD01hGjmZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="5158991" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="5158991" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 01:15:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="1098335938" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="1098335938" Received: from tjquresh-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.76]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 01:14:59 -0800 From: Jani Nikula To: Jiapeng Chong Subject: Re: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero In-Reply-To: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> Date: Wed, 22 Nov 2023 11:14:57 +0200 Message-ID: <87y1eqm9ny.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tvrtko.ursulin@linux.intel.com, Mika Kahola , Jiapeng Chong , intel-gfx@lists.freedesktop.org, Abaci Robot , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 22 Nov 2023, Jiapeng Chong wrote: > The entry_setup_frames is defined as u8 type, else(entry_setup_frames < 0) > is invalid. At the same time, the return value of function > intel_psr_entry_setup_frames is also of type int. so modified > its type to int. > > ./drivers/gpu/drm/i915/display/intel_psr.c:1336:5-23: WARNING: Unsigned expression compared with zero: entry_setup_frames >= 0. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7610 > Signed-off-by: Jiapeng Chong There's already a patch. Mika, please follow up with it. https://patchwork.freedesktop.org/patch/msgid/20231116090512.480373-1-mika.kahola@intel.com > --- > drivers/gpu/drm/i915/display/intel_psr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index 8d180132a74b..204da50e3f28 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp *intel_dp, > { > struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); > const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; > - u8 entry_setup_frames; > + int entry_setup_frames; > > /* > * Current PSR panels don't work reliably with VRR enabled -- Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99949C61D9C for ; Wed, 22 Nov 2023 09:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235095AbjKVJPN (ORCPT ); Wed, 22 Nov 2023 04:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjKVJPK (ORCPT ); Wed, 22 Nov 2023 04:15:10 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87720D50 for ; Wed, 22 Nov 2023 01:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700644507; x=1732180507; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=RrwEo1VDHhlnf+Pa2Ly1JESTxjciztMmCHm/k/NWo+I=; b=IljyKAstK43LvtP3ihmH3gkFd9kZgSd220EieD2c1uV3u3TeDqbPLDeP EkdXpDwYuFrhA2aAgBfW5mRfa8H60jcarjXXdC/EwQyJjg15e+8vZRDdK e2mlC+GyqxK9GhM2BUCqbXLtsIzmK9PIrhcJgYqyhZgRwCbuDvC3RXxEe 3rQ/U9hnr8DoUBtPt6GHeGeuzY1swdnX+U5LRfcvJG/AGMtfSZEzkBO76 8ZEUiJiVdJYoyKhSApVAyujyWawagQheI4+8m65v4F/yLJBz5U2ZhDer/ 0cuZb3qj9Wztsabn0JL1WoZXsaHxAmSwnevQ4NTQeN7R738QgTmU7fIGK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="5158989" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="5158989" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 01:15:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="1098335938" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="1098335938" Received: from tjquresh-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.76]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 01:14:59 -0800 From: Jani Nikula To: Jiapeng Chong Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot , Mika Kahola Subject: Re: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero In-Reply-To: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> Date: Wed, 22 Nov 2023 11:14:57 +0200 Message-ID: <87y1eqm9ny.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Nov 2023, Jiapeng Chong wrote: > The entry_setup_frames is defined as u8 type, else(entry_setup_frames < 0) > is invalid. At the same time, the return value of function > intel_psr_entry_setup_frames is also of type int. so modified > its type to int. > > ./drivers/gpu/drm/i915/display/intel_psr.c:1336:5-23: WARNING: Unsigned expression compared with zero: entry_setup_frames >= 0. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7610 > Signed-off-by: Jiapeng Chong There's already a patch. Mika, please follow up with it. https://patchwork.freedesktop.org/patch/msgid/20231116090512.480373-1-mika.kahola@intel.com > --- > drivers/gpu/drm/i915/display/intel_psr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index 8d180132a74b..204da50e3f28 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp *intel_dp, > { > struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); > const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; > - u8 entry_setup_frames; > + int entry_setup_frames; > > /* > * Current PSR panels don't work reliably with VRR enabled -- Jani Nikula, Intel