From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.com>,
"lakshmiy@us.ibm.com" <lakshmiy@us.ibm.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"joel@jms.id.au" <joel@jms.id.au>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"ninad@linux.ibm.com" <ninad@linux.ibm.com>,
"eajames@linux.ibm.com" <eajames@linux.ibm.com>,
"wsa@kernel.org" <wsa@kernel.org>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to client devices
Date: Thu, 12 Oct 2023 18:08:03 +0300 [thread overview]
Message-ID: <87y1g7zxnw.fsf@intel.com> (raw)
In-Reply-To: <bf0d71383958e7cc88bc84c7e2378f10d3a486f3.camel@suse.com>
On Thu, 12 Oct 2023, Jean Delvare <jdelvare@suse.com> wrote:
> On Mon, 2023-10-09 at 16:14 -0500, Lakshmi Yadlapati wrote:
>> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
>> ---
>> drivers/i2c/i2c-core-base.c | 8 +-
>> drivers/i2c/i2c-core-smbus.c | 143 ++++++++++++++++++++++++++++-------
>> drivers/i2c/i2c-core.h | 23 ++++++
>> include/linux/i2c.h | 2 +
>> 4 files changed, 145 insertions(+), 31 deletions(-)
>> (...)
>
> Non-trivial patch with no description -> not even looking, sorry. You
> can't possibly propose a change to the core of a subsystem and not
> bother explaining why this change is needed or what purpose it serves.
We've even managed to write extensive documentation on this!
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
>
> (And yes I know there's some information in patch 0/2, but that's not
> going to make it into git, so it will be lost. Commits should be self-
> sufficient, not only the implementation, but also the description.)
>
> I would also suggest trimming the To and Cc lists. I can't really see
> how linux-media and dri-devel are relevant here for example.
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.com>,
"lakshmiy@us.ibm.com" <lakshmiy@us.ibm.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"joel@jms.id.au" <joel@jms.id.au>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"ninad@linux.ibm.com" <ninad@linux.ibm.com>,
"eajames@linux.ibm.com" <eajames@linux.ibm.com>,
"wsa@kernel.org" <wsa@kernel.org>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to client devices
Date: Thu, 12 Oct 2023 18:08:03 +0300 [thread overview]
Message-ID: <87y1g7zxnw.fsf@intel.com> (raw)
In-Reply-To: <bf0d71383958e7cc88bc84c7e2378f10d3a486f3.camel@suse.com>
On Thu, 12 Oct 2023, Jean Delvare <jdelvare@suse.com> wrote:
> On Mon, 2023-10-09 at 16:14 -0500, Lakshmi Yadlapati wrote:
>> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
>> ---
>> drivers/i2c/i2c-core-base.c | 8 +-
>> drivers/i2c/i2c-core-smbus.c | 143 ++++++++++++++++++++++++++++-------
>> drivers/i2c/i2c-core.h | 23 ++++++
>> include/linux/i2c.h | 2 +
>> 4 files changed, 145 insertions(+), 31 deletions(-)
>> (...)
>
> Non-trivial patch with no description -> not even looking, sorry. You
> can't possibly propose a change to the core of a subsystem and not
> bother explaining why this change is needed or what purpose it serves.
We've even managed to write extensive documentation on this!
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
>
> (And yes I know there's some information in patch 0/2, but that's not
> going to make it into git, so it will be lost. Commits should be self-
> sufficient, not only the implementation, but also the description.)
>
> I would also suggest trimming the To and Cc lists. I can't really see
> how linux-media and dri-devel are relevant here for example.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-12 15:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 21:14 [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses Lakshmi Yadlapati
2023-10-09 21:14 ` Lakshmi Yadlapati
2023-10-09 21:14 ` [PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to client devices Lakshmi Yadlapati
2023-10-09 21:14 ` Lakshmi Yadlapati
2023-10-12 14:18 ` Jean Delvare
2023-10-12 14:18 ` Jean Delvare
2023-10-12 15:08 ` Jani Nikula [this message]
2023-10-12 15:08 ` Jani Nikula
2023-10-09 21:14 ` [PATCH v1 2/2] hwmon: (pmbus/max31785) Add minimum delay between bus accesses Lakshmi Yadlapati
2023-10-09 21:14 ` Lakshmi Yadlapati
2023-10-09 22:10 ` [PATCH v1 0/2] [PATCH] " Lakshmi Yadlapati
2023-10-09 22:10 ` Lakshmi Yadlapati
2023-10-10 9:31 ` Wolfram Sang
2023-10-10 9:31 ` Wolfram Sang
2023-10-10 13:45 ` Guenter Roeck
2023-10-10 18:58 ` Wolfram Sang
2023-10-10 18:58 ` Wolfram Sang
2023-10-10 22:59 ` Guenter Roeck
2023-10-11 3:54 ` Andrew Jeffery
2023-10-11 16:14 ` Lakshmi Yadlapati
2023-10-11 16:27 ` Wolfram Sang
2023-10-11 16:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1g7zxnw.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lakshmiy@us.ibm.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ninad@linux.ibm.com \
--cc=sumit.semwal@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.