From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C20CCDB46E for ; Thu, 12 Oct 2023 11:42:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqu4Q-0006tj-O0; Thu, 12 Oct 2023 07:41:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqu4O-0006ta-V9 for qemu-devel@nongnu.org; Thu, 12 Oct 2023 07:41:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqu4N-0000cF-Ft for qemu-devel@nongnu.org; Thu, 12 Oct 2023 07:41:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697110894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jESRy1M0i2FzsNYrNAeZGIdtEHvvflh2/WIQVZt1lcE=; b=Rxrq1EhmA92TPKv6GMXov0gdl4m+CVCX8ZgVBLWoe41G7D09NyE30fKmTdhpQeVT2VNxLU IdIaNjqUGUPodUNCVgsZWR2xyduuqrueJPaGyOkt6kkWHO5FqFWHs2j0JOl/kKZ6b+BTfH IADu4+lrn7gU5np+9Kki/C0WdXOzp2Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-348-iG7JMOqkOn-GX8jAbZzwmA-1; Thu, 12 Oct 2023 07:41:26 -0400 X-MC-Unique: iG7JMOqkOn-GX8jAbZzwmA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86222185A79B; Thu, 12 Oct 2023 11:41:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 615D520296DB; Thu, 12 Oct 2023 11:41:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6402621E6A1F; Thu, 12 Oct 2023 13:41:24 +0200 (CEST) From: Markus Armbruster To: Nina Schoetterl-Glausch Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Eduardo Habkost , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , David Hildenbrand , Halil Pasic , Christian Borntraeger , Eric Farman , Thomas Huth , Eric Blake , Michael Roth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yanan Wang , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Ilya Leoshkevich , Cleber Rosa , Wainer dos Santos Moschetta , Beraldo Leal , Pierre Morel Subject: Re: [PATCH v25 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command References: <20231005160155.1945588-1-nsg@linux.ibm.com> <20231005160155.1945588-14-nsg@linux.ibm.com> Date: Thu, 12 Oct 2023 13:41:24 +0200 In-Reply-To: <20231005160155.1945588-14-nsg@linux.ibm.com> (Nina Schoetterl-Glausch's message of "Thu, 5 Oct 2023 18:01:47 +0200") Message-ID: <87y1g8xe3f.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Nina Schoetterl-Glausch writes: > From: Pierre Morel > > The query-s390x-cpu-polarization qmp command returns the current > CPU polarization of the machine. > > Signed-off-by: Pierre Morel > Reviewed-by: Thomas Huth > Reviewed-by: Nina Schoetterl-Glausch > Co-developed-by: Nina Schoetterl-Glausch > Signed-off-by: Nina Schoetterl-Glausch > --- > qapi/machine-target.json | 30 ++++++++++++++++++++++++++++++ > hw/s390x/cpu-topology.c | 8 ++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/qapi/machine-target.json b/qapi/machine-target.json > index 02f1de5d02..10289835fb 100644 > --- a/qapi/machine-target.json > +++ b/qapi/machine-target.json > @@ -451,3 +451,33 @@ > 'features': [ 'unstable' ], > 'if': { 'all': [ 'TARGET_S390X', 'CONFIG_KVM' ] } > } > + > +## > +# @CpuPolarizationInfo: > +# > +# The result of a CPU polarization query. > +# > +# @polarization: the CPU polarization > +# > +# Since: 8.2 > +## > +{ 'struct': 'CpuPolarizationInfo', > + 'data': { 'polarization': 'CpuS390Polarization' }, > + 'if': { 'all': [ 'TARGET_S390X', 'CONFIG_KVM' ] } > +} > + > +## > +# @query-s390x-cpu-polarization: > +# > +# Features: > +# > +# @unstable: This command is experimental. > +# > +# Returns: the machine's CPU polarization > +# > +# Since: 8.2 > +## > +{ 'command': 'query-s390x-cpu-polarization', 'returns': 'CpuPolarizationInfo', > + 'features': [ 'unstable' ], > + 'if': { 'all': [ 'TARGET_S390X', 'CONFIG_KVM' ] } > +} > diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c > index 327bccea4f..f16bdf65fa 100644 > --- a/hw/s390x/cpu-topology.c > +++ b/hw/s390x/cpu-topology.c > @@ -459,3 +459,11 @@ void qmp_set_cpu_topology(uint16_t core, > has_drawer, drawer, has_entitlement, entitlement, > has_dedicated, dedicated, errp); > } > + > +CpuPolarizationInfo *qmp_query_s390x_cpu_polarization(Error **errp) > +{ > + CpuPolarizationInfo *info = g_new0(CpuPolarizationInfo, 1); > + > + info->polarization = s390_topology.polarization; > + return info; > +} Acked-by: Markus Armbruster