From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Björn Töpel" <bjorn@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Eric Dumazet" <edumazet@google.com>,
"Hao Luo" <haoluo@google.com>, "Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jiri Olsa" <jolsa@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Paolo Abeni" <pabeni@redhat.com>, "Song Liu" <song@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Yonghong Song" <yonghong.song@linux.dev>
Subject: Re: [PATCH bpf-next] net: Add a warning if NAPI cb missed xdp_do_flush().
Date: Fri, 29 Sep 2023 19:52:00 +0200 [thread overview]
Message-ID: <87y1goc1fj.fsf@toke.dk> (raw)
In-Reply-To: <20230929165825.RvwBYGP1@linutronix.de>
Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:
> A few drivers were missing a xdp_do_flush() invocation after
> XDP_REDIRECT.
>
> Add three helper functions each for one of the per-CPU lists. Return
> true if the per-CPU list is non-empty and flush the list.
> Add xdp_do_check_flushed() which invokes each helper functions and
> creats a warning if one of the functions had a non-empty list.
> Hide everything behind CONFIG_DEBUG_NET.
>
> Suggested-by: Jesper Dangaard Brouer <hawk@kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>
> This is follow-up to
> https://lore.kernel.org/all/cb2f7931-5ae5-8583-acff-4a186fed6632@kernel.org
>
> It has been compile tested.
Both with and without CONFIG_DEBUG_NET enabled, I trust? ;)
Anyway, LGTM!
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2023-09-29 17:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:58 [PATCH bpf-next] net: Add a warning if NAPI cb missed xdp_do_flush() Sebastian Andrzej Siewior
2023-09-29 17:52 ` Toke Høiland-Jørgensen [this message]
2023-10-04 14:09 ` Jakub Kicinski
2023-10-06 15:49 ` [PATCH bpf-next v2] " Sebastian Andrzej Siewior
2023-10-06 17:21 ` kernel test robot
2023-10-06 19:31 ` Jakub Kicinski
2023-10-07 15:43 ` [PATCH bpf-next v3] " Sebastian Andrzej Siewior
2023-10-10 6:57 ` [PATCH bpf-next -v4] " Sebastian Andrzej Siewior
2023-10-11 4:42 ` John Fastabend
2023-10-16 11:56 ` Daniel Borkmann
2023-10-16 12:57 ` [PATCH bpf-next -v5] " Sebastian Andrzej Siewior
2023-10-17 13:10 ` patchwork-bot+netdevbpf
2023-10-08 13:48 ` [PATCH bpf-next v2] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1goc1fj.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.