From: Jani Nikula <jani.nikula@linux.intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/3] drm/i915/hdcp: Remove i915 check stubs
Date: Fri, 22 Sep 2023 12:27:13 +0300 [thread overview]
Message-ID: <87y1gyo8we.fsf@intel.com> (raw)
In-Reply-To: <20230922082909.334085-2-suraj.kandpal@intel.com>
On Fri, 22 Sep 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> Remove i915 check stubs the subsequent patch will add function
> which implements a cleaner method to share code between
> i915 and Xe
This should be a fixup! patch to whichever commit in drm-xe-next
introduced the changes.
See git commit --fixup to generate the annotation for that.
BR,
Jani.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index f617ccd206c8..a42549fa9691 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -174,7 +174,6 @@ bool intel_hdcp2_capable(struct intel_connector *connector)
>
> /* If MTL+ make sure gsc is loaded and proxy is setup */
> if (intel_hdcp_gsc_cs_required(i915)) {
> -#ifdef I915
> struct intel_gt *gt = i915->media_gt;
> struct intel_gsc_uc *gsc = gt ? >->uc.gsc : NULL;
>
> @@ -183,10 +182,6 @@ bool intel_hdcp2_capable(struct intel_connector *connector)
> "GSC components required for HDCP2.2 are not ready\n");
> return false;
> }
> -#else
> - /* TODO */
> - return false;
> -#endif
> }
>
> /* MEI/GSC interface is solid depending on which is used */
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-09-22 9:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 8:29 [Intel-xe] [PATCH 0/3] Remove Stubs in HDCP code Suraj Kandpal
2023-09-22 8:29 ` [Intel-xe] [PATCH 1/3] drm/i915/hdcp: Remove i915 check stubs Suraj Kandpal
2023-09-22 9:27 ` Jani Nikula [this message]
2023-09-22 10:14 ` Kandpal, Suraj
2023-09-22 10:38 ` [Intel-xe] [PATCH 1/3] fixup! FIXME: drm/i915: xe doesn't have gsc hdcp interface or something Suraj Kandpal
2023-10-09 8:52 ` Shankar, Uma
2023-10-09 8:58 ` Kandpal, Suraj
2023-10-09 9:16 ` Shankar, Uma
2023-09-22 8:29 ` [Intel-xe] [PATCH 2/3] drm/i915/hdcp: Move checks for gsc health status Suraj Kandpal
2023-09-22 8:29 ` [Intel-xe] [PATCH 3/3] drm/xe/hdcp: Define intel_hdcp_gsc_check_status in Xe Suraj Kandpal
2023-10-09 9:19 ` Shankar, Uma
2023-09-22 8:58 ` [Intel-xe] ✗ CI.Patch_applied: failure for Remove Stubs in HDCP code (rev2) Patchwork
2023-09-22 9:29 ` [Intel-xe] [PATCH 0/3] Remove Stubs in HDCP code Jani Nikula
2023-09-22 10:13 ` Kandpal, Suraj
2023-09-22 10:59 ` [Intel-xe] ✓ CI.Patch_applied: success for Remove Stubs in HDCP code (rev3) Patchwork
2023-09-22 10:59 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-22 11:00 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-22 11:07 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-22 11:07 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-22 11:09 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-22 11:42 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1gyo8we.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.