From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08A7DC0015E for ; Thu, 27 Jul 2023 15:17:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5102110E13C; Thu, 27 Jul 2023 15:17:02 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45D9710E13C for ; Thu, 27 Jul 2023 15:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690471018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pp7lX2S4BE1VOAd+Ohe4qOsAj8X9hgCenh8uffGy52U=; b=Jkyb2Zbfdmz31mw7R1OZoDzUAeMtT6Y+oO7v3dok5nI9Rs+r5eefqaXr4pfhQUW9Bm8sCY z+scWc6DZC0xKIQ/hkx7flxezC5xSqvnW1VCF8t4XfwON8uTAlp8iSD4bHk5ykfJqSYbQ9 2EyD/McMmOeDIGaUIcXWa3cl8PNcT+8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-sUcA-8NpPZ2dcIydF6V6qg-1; Thu, 27 Jul 2023 11:16:56 -0400 X-MC-Unique: sUcA-8NpPZ2dcIydF6V6qg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3172a94b274so564856f8f.0 for ; Thu, 27 Jul 2023 08:16:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690471015; x=1691075815; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pp7lX2S4BE1VOAd+Ohe4qOsAj8X9hgCenh8uffGy52U=; b=d6osFj9/Hv6y992XD7AXNFR2oGi/pNEZDRMr0gOF7DMbVAAFy/0AON8GMgIGikDu7D 2CftFVPyjM/Rj2DS9QHiPvxwxoT3qLAJi+HjPEewdAGbwxPmVs0eUSbqoMe6gDFi2Vr0 iYMWB0Rna4riugyCd+7TgyiwqxU9JuH1CUj3oImLjFu1fAP/5MtXjiqb33kcBvqIGVQA 1dGdXAaZvY0Gcdt57D0f8E9FrMQuHWqtDiX9Jeum3maxnmaW7LxTDWwFAyUiYmb1WXyT uePpEgWUa8Ms3PgAdzosOwRWLOGTAL68o6+MYsUvfmFMSaMY7/aV47LfXwDLCnj7NKtE bkMg== X-Gm-Message-State: ABy/qLYi6861WgoWmLvI8AXjkN5JCV9A4gvF//LzJPdQ2uRC9J1sJe9a ORNiLnrYN90j1uw3yHatZ26GRIuY+lqPnI6QrMkGcdWHbzAHBvC9AuG4iPMtid572O2uTBun/R4 nu0nfOKznZzfTXpYpqBi7aaVbhmkz X-Received: by 2002:adf:fc05:0:b0:317:5de3:86fb with SMTP id i5-20020adffc05000000b003175de386fbmr1932626wrr.10.1690471015016; Thu, 27 Jul 2023 08:16:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlGFJTm1x26WKX+ZJ5GVgIV/5/cEhdRTj0qRIs77CCN9iPmG4jfZSNpagqJH+qPLWxdEJ7LocQ== X-Received: by 2002:adf:fc05:0:b0:317:5de3:86fb with SMTP id i5-20020adffc05000000b003175de386fbmr1932612wrr.10.1690471014678; Thu, 27 Jul 2023 08:16:54 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h18-20020adff192000000b003113ed02080sm2265368wro.95.2023.07.27.08.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 08:16:54 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/ssd130x: Use shadow-buffer helpers when managing plane's state In-Reply-To: <0ce32153-cfc0-e701-3863-803fcdb897ff@suse.de> References: <20230727140453.577445-1-javierm@redhat.com> <0ce32153-cfc0-e701-3863-803fcdb897ff@suse.de> Date: Thu, 27 Jul 2023 17:16:53 +0200 Message-ID: <87y1j1tme2.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , Arnd Bergmann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thomas Zimmermann writes: Hello Thomas, > Hi Javier > > Am 27.07.23 um 16:04 schrieb Javier Martinez Canillas: >> The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's >> .atomic_check() callback") moved the buffers allocation to be done in >> the primary plane's .atomic_check() callback. >> >> But it missed that since the driver uses a shadow-buffered plane, the >> __drm_gem_{reset,duplicate,destroy}_shadow_plane() helper functions >> must be used in the struct drm_plane_funcs handlers. >> >> This was missed because the mentioned commit did not remove the macro >> DRM_GEM_SHADOW_PLANE_FUNCS, which leads to the custom plane's atomic >> state management handlers to not be used. >> >> Fixes: 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") >> Reported-by: Arnd Bergmann > > Reported-by needs to be followed by > > Closes: > > where would point to Arnd's bug report on dri-devel. > Ah, I thought checkpatch complaining about it but since we already add a Link: with dim, didn't know what to add there. Makes sense to add Arnd's report indeed. I can include it when applying instead of posting a v2 if you don't mind. >> Suggested-by: Thomas Zimmermann >> Signed-off-by: Javier Martinez Canillas > > This looks correct now. Thanks for fixing this bug quickly. With the > Close added: > > Reviewed-by: Thomas Zimmermann > Thanks and to you for pointing that out. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7657C05051 for ; Thu, 27 Jul 2023 15:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232772AbjG0PSM (ORCPT ); Thu, 27 Jul 2023 11:18:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234516AbjG0PRu (ORCPT ); Thu, 27 Jul 2023 11:17:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AEA119BA for ; Thu, 27 Jul 2023 08:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690471020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pp7lX2S4BE1VOAd+Ohe4qOsAj8X9hgCenh8uffGy52U=; b=UV141jlwuyQs1PPe0lIWTzrbgQmVqE/02ksud2UoC7Caqdu0TDci0jJG1X6UDhST7mQKLk ZYZqhGx9rg3qgB8rmp6WsU951sXnvzxlpAfOY3pBjvxA8tte130pZij0AzU64rTBzLB1Nf B11czmMeVjAif1OtrWlagy6FrGLbcmI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-kmci5ySlMm2bqfyq1Mmlrg-1; Thu, 27 Jul 2023 11:16:56 -0400 X-MC-Unique: kmci5ySlMm2bqfyq1Mmlrg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fd22a4cf2dso6329305e9.2 for ; Thu, 27 Jul 2023 08:16:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690471015; x=1691075815; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pp7lX2S4BE1VOAd+Ohe4qOsAj8X9hgCenh8uffGy52U=; b=dem0Kg4EHMR97dkQoZvj3nFFOseKnYiyHQc5JlIMLhb4LylcvzsA3FNGmz1/6VJeBC pFkiXrN4Unhb+13Yjbz4xeW3PL77aZg900WpAsKClnC2muAq9owv07TWWjoLmcI425zm 83u2znKCZ/rJkk1jqv63pCbm8QzJ6jliR2uhXeQTwiv+5Xe9ASOZECPfnGAwJkDVwxKj sdMTyr1ZA8jKD9p/uKvrn9VRSjVPT67hBLVkuNluH7+ZGkIqWWLaQdWi0Wq12PY4IhsL +Y94D05IwAA/6WpBggWsSxzQfYYm7RekNdrgws/gEBe5SFfNexTsHylR18YCOObaMO+q lpFw== X-Gm-Message-State: ABy/qLafjbLJwkDX4eYkwsr0sYsDWEzbN9OTIGEzPybI+6UYu0ySUEzC TcQWQErSS0VTSBeWYwj64urKcfCtRoyp+F5RWhuPVYxDNG6UdpgNtAQ4ViJMt/DyGGfbnQyxBw8 B+KBXeufNK6zhTicQqeV/H9jf X-Received: by 2002:adf:fc05:0:b0:317:5de3:86fb with SMTP id i5-20020adffc05000000b003175de386fbmr1932627wrr.10.1690471015016; Thu, 27 Jul 2023 08:16:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlGFJTm1x26WKX+ZJ5GVgIV/5/cEhdRTj0qRIs77CCN9iPmG4jfZSNpagqJH+qPLWxdEJ7LocQ== X-Received: by 2002:adf:fc05:0:b0:317:5de3:86fb with SMTP id i5-20020adffc05000000b003175de386fbmr1932612wrr.10.1690471014678; Thu, 27 Jul 2023 08:16:54 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h18-20020adff192000000b003113ed02080sm2265368wro.95.2023.07.27.08.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 08:16:54 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Maxime Ripard , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/ssd130x: Use shadow-buffer helpers when managing plane's state In-Reply-To: <0ce32153-cfc0-e701-3863-803fcdb897ff@suse.de> References: <20230727140453.577445-1-javierm@redhat.com> <0ce32153-cfc0-e701-3863-803fcdb897ff@suse.de> Date: Thu, 27 Jul 2023 17:16:53 +0200 Message-ID: <87y1j1tme2.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Zimmermann writes: Hello Thomas, > Hi Javier > > Am 27.07.23 um 16:04 schrieb Javier Martinez Canillas: >> The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's >> .atomic_check() callback") moved the buffers allocation to be done in >> the primary plane's .atomic_check() callback. >> >> But it missed that since the driver uses a shadow-buffered plane, the >> __drm_gem_{reset,duplicate,destroy}_shadow_plane() helper functions >> must be used in the struct drm_plane_funcs handlers. >> >> This was missed because the mentioned commit did not remove the macro >> DRM_GEM_SHADOW_PLANE_FUNCS, which leads to the custom plane's atomic >> state management handlers to not be used. >> >> Fixes: 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback") >> Reported-by: Arnd Bergmann > > Reported-by needs to be followed by > > Closes: > > where would point to Arnd's bug report on dri-devel. > Ah, I thought checkpatch complaining about it but since we already add a Link: with dim, didn't know what to add there. Makes sense to add Arnd's report indeed. I can include it when applying instead of posting a v2 if you don't mind. >> Suggested-by: Thomas Zimmermann >> Signed-off-by: Javier Martinez Canillas > > This looks correct now. Thanks for fixing this bug quickly. With the > Close added: > > Reviewed-by: Thomas Zimmermann > Thanks and to you for pointing that out. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat