Re: [PATCH v6 4/6] qapi: Add HvBalloonDeviceInfo sub-type to MemoryDeviceInfo

[Markus Armbruster <armbru@redhat.com>]

"Maciej S. Szmigiero" <mail@maciej.szmigiero.name> writes:

> On 24.07.2023 13:37, Markus Armbruster wrote:
>> "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> writes:
>> 
>>> From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
>>>
>>> Used by the hv-balloon driver to report its provided memory state
>>> information.
>>>
>>> Co-developed-by: David Hildenbrand <david@redhat.com>
>>> Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
>>> ---
>>>   hw/core/machine-hmp-cmds.c | 15 +++++++++++++++
>>>   qapi/machine.json          | 39 ++++++++++++++++++++++++++++++++++++--
>>>   2 files changed, 52 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c
>>> index c3e55ef9e9cd..7b06ed35decb 100644
>>> --- a/hw/core/machine-hmp-cmds.c
>>> +++ b/hw/core/machine-hmp-cmds.c
>>> @@ -247,6 +247,7 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
>>>       MemoryDeviceInfo *value;
>>>       PCDIMMDeviceInfo *di;
>>>       SgxEPCDeviceInfo *se;
>>> +    HvBalloonDeviceInfo *hi;
>>>         for (info = info_list; info; info = info->next) {
>>>           value = info->value;
>>> @@ -304,6 +305,20 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict)
>>>                   monitor_printf(mon, "  node: %" PRId64 "\n", se->node);
>>>                   monitor_printf(mon, "  memdev: %s\n", se->memdev);
>>>                   break;
>>> +            case MEMORY_DEVICE_INFO_KIND_HV_BALLOON:
>>
>> This is the only occurence of MEMORY_DEVICE_INFO_KIND_HV_BALLOON at the
>> end of the series.  Where are MemoryDeviceInfo with this union tag
>> created?
>
> From patch 6:
[...]

I messed around with git, and managed to confuse myself.  Thanks for
your help!