From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 3/3] ALSA: emu10k1: (re-)add mixer locking
Date: Thu, 13 Jul 2023 13:56:28 +0200 [thread overview]
Message-ID: <87y1jkdnyr.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZK/X07ZfVZ+geigm@ugly>
On Thu, 13 Jul 2023 12:54:11 +0200,
Oswald Buddenhagen wrote:
>
> On Thu, Jul 13, 2023 at 12:24:28PM +0200, Takashi Iwai wrote:
> > Well, I took your patch 3 just because you wanted to have a protection
> > of your data from both get/put callback and from another code path in
> > another patch. It was an (ab)use of controls->rwsem that couldn't be
> > accepted, so the patch 3 was taken as an alternative.
> >
> > If this isn't the scenario, let me know: I'd rather drop the patch
> > again, as it's superfluous.
> >
> ok, then please drop it.
>
> you're quite right that this is the scenario, but i can do that
> selectively just as well, like it already is the case in some other
> callbacks. i just wanted to have this patch first if it was to be
> applied at all, because it seemed cleaner.
OK, dropped now.
thanks,
Takashi
next prev parent reply other threads:[~2023-07-13 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 14:57 [PATCH 1/3] ALSA: emu10k1: fix return value of snd_emu1010_adc_pads_put() Oswald Buddenhagen
2023-07-12 14:57 ` [PATCH 2/3] ALSA: emu10k1: remove superfluous IRQ enable state saving Oswald Buddenhagen
2023-07-13 5:55 ` Takashi Iwai
2023-07-13 8:15 ` Oswald Buddenhagen
2023-07-13 8:27 ` Takashi Iwai
2023-07-13 8:30 ` Takashi Iwai
2023-07-12 14:57 ` [PATCH 3/3] ALSA: emu10k1: (re-)add mixer locking Oswald Buddenhagen
2023-07-13 8:33 ` Takashi Iwai
2023-07-13 9:07 ` Oswald Buddenhagen
2023-07-13 9:21 ` Takashi Iwai
2023-07-13 10:01 ` Oswald Buddenhagen
2023-07-13 10:24 ` Takashi Iwai
2023-07-13 10:54 ` Oswald Buddenhagen
2023-07-13 11:56 ` Takashi Iwai [this message]
2023-07-13 5:58 ` [PATCH 1/3] ALSA: emu10k1: fix return value of snd_emu1010_adc_pads_put() Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1jkdnyr.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.