From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79600C7EE22 for ; Mon, 8 May 2023 22:18:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0BBC482184; Mon, 8 May 2023 22:18:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0BBC482184 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1683584335; bh=73D8PL4DsJIkNZZPjfmOHUBzuqyfo6RVgB/hjrqgOmA=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=c7cLum1rBBVmLUzXVgtRP8Vwg7WSutxg+9twQ4uHHGU7LyqccBZ+1YCuV9hBarwEd hYZ2YaVmLevKHloYXaGwaw+iVeF44F7gPy4EBZvRctlrkcRKGnybg39ug0FasdTcP1 2seMqCoBRypE8sm2y5egpRQKRlBlWgUPYK4ahIC07+DEsxFEz+S4ZLN4spXdETAEKe O8yJzTiC013NoXxaiw8l+wLF1nZq3c/NN95EKXjY2G1y/4RmYxT+sJntxgr/lNrETS VYcr5J9xbYwfI81E4qphiHgmCmGgPniGcyZbZXnDhJqRnPKTjF6LqyDTecM2G7Pt88 WwD8W6YQ1G3nQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aGD-xjmbV_Yw; Mon, 8 May 2023 22:18:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 16D4882176; Mon, 8 May 2023 22:18:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 16D4882176 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 29CA61BF2A2 for ; Mon, 8 May 2023 22:18:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F410A4185D for ; Mon, 8 May 2023 22:18:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F410A4185D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZfKrcvZHtWU4 for ; Mon, 8 May 2023 22:18:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7421C417AF Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7421C417AF for ; Mon, 8 May 2023 22:18:50 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="338992811" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="338992811" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 15:18:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="768223338" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="768223338" Received: from vcostago-mobl3.jf.intel.com (HELO vcostago-mobl3) ([10.24.14.106]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 15:18:48 -0700 From: Vinicius Costa Gomes To: Tony Nguyen , intel-wired-lan@lists.osuosl.org In-Reply-To: <970e057f-eed9-69ae-b321-ff78049e33ac@intel.com> References: <20230504235233.1850428-1-vinicius.gomes@intel.com> <970e057f-eed9-69ae-b321-ff78049e33ac@intel.com> Date: Mon, 08 May 2023 15:18:48 -0700 Message-ID: <87y1lytqk7.fsf@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683584330; x=1715120330; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=4mDmJYTj89fro2FBVJrLtZ4oIJlAodgterU1JbMAZsk=; b=RB3sn5Mu23Fn2JBND7/mSUA14zSwDMMy9Xi6PeQHe7SIGTtYsooxG3PW q/TR7CGl/XwoUug98dJYXYzBUagVf/KM9lS81dbjPUTDaHDIggK53IeYZ WmXtZlEW8yC4Y0P3Wm0wxvJJkkNbOBw7MHVeotJN8IQkHXPLBavdvIt0Z cVTPAwCul0j+bJVvLMwYD++uTUmT0IF+t3Odu0jc/Z6CAFcxT6lhcGqKZ XRSsW7x1h0OrsJroZNSmVHG3SWXkaKbs4cc7cxefGmviclpN1IXwMo2UN gNxtweYplI07eBfMljq8ChUFxJHRQ5tw9SDm2ugwBRMRIkIc3QWZlU/0H g==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RB3sn5Mu Subject: Re: [Intel-wired-lan] [PATCH iwl v1 0/5] igc: TX timestamping fixes X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kurt@linutronix.de, vladimir.oltean@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tony Nguyen writes: > On 5/4/2023 4:52 PM, Vinicius Costa Gomes wrote: >> Hi, >> >> Changes from the "for-next-queue" version: >> - As this is intended for the iwl/net-queue tree, removed adding >> support for adding the "extra" tstamp registers; >> - Added "Fixes:" tags to the appropriate patches (Vladimir Oltean); > > In most cases, net patches should have Fixes: tags to them. Patches 3 > and 5 don't have them and it seems like it would be applicable to them. > Patch 3 is directly related to patch 1, but I think it deserved a separate commit, as it has a bit of refactor. I can squash it into patch 1, if you think it's better I can do that, no worries, I was only afraid to make the patch harder to follow. Patch 5, as a hardware issue workaround, I didn't know if adding a 'Fixes:' tag made sense, but as a way to direct patches to the right stable trees, that would be a good point in favor, even if it's not fixing a bug in the code. Is this what you had in mind? If so, I can do that. > Patch 4 seems more like an improvement than a bug fix? If so, -next > would seem a better path for that patch. Based on the 'for-next-queue > version' link, there are still some patches remaining that will go > through -next? Perhaps this can go with them. > On a very loaded system, for example, time synchronization can fail if something blocks the system workqueue from running, so in a sense, that patches fixes/helps some user visible issues. But I can see it both ways, that this is an improvement. What's your preference? >> - Improved the check to catch the case that the skb has the >> SKBTX_HW_TSTAMP flag, but TX timestamping is not enabled (Vladimir >> Oltean); >> - Ony check for timestamping timeouts if TX timestamping is enabled >> (Vladimir Oltean); >> >> for-next-queue version link: >> https://lore.kernel.org/intel-wired-lan/20230228054534.1093483-1-vinicius.gomes@intel.com/ > > ... > >> BTW: I hope this is the correct usage of the "iwl" subject prefix. > > If you could also add -net|-next for the (eventual) target tree > i.e. > net : iwl-net > net-next : iwl-next > > in this case 'iwl-net' Yeah, I sent this patch a couple minutes before seeing the email about the subject prefix conventions. Will use the correct one next time. > > Thanks, > Tony -- Vinicius _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan