From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D9C6C7619A for ; Wed, 5 Apr 2023 11:31:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 199F110E8EA; Wed, 5 Apr 2023 11:31:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5E5C10E8EA for ; Wed, 5 Apr 2023 11:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdvlAOB2HBtoxdSNuZT4WKN+Yt+RUmrcPHkXhNSXjuo=; b=g8WdMuY81EJmL5GZxq9i3ONAMJU+dwkuBob3u2BD66IPTpyzERouTJzVugQ7D8pRR/hjRz 1NOJcF9uiQq7v6hRR/sVXorGQxpHKLDJLOPXxPwerHfQPLWDp2Lzyu7zW2ra9MZ5rj08mo UZ1dlmcIFgZn4BtXN+xVq+Csaqzm3OM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-498-NS0dAmdQMEewMyjDKHVgwA-1; Wed, 05 Apr 2023 07:31:46 -0400 X-MC-Unique: NS0dAmdQMEewMyjDKHVgwA-1 Received: by mail-wm1-f72.google.com with SMTP id n19-20020a05600c3b9300b003ef63ef4519so15844871wms.3 for ; Wed, 05 Apr 2023 04:31:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694305; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DdvlAOB2HBtoxdSNuZT4WKN+Yt+RUmrcPHkXhNSXjuo=; b=yyfarRzCdB+j9zptgUFUCzE+tKbnikrDHsXxMS6WjnBtXZjCK+3zrDzEm8r7UmKrYr +xOvnyqG0v5B5YPmpB/ql80vTAPYP84gLaH/ZRYnS//ZqRdF/83ARN2uLEqBXGCtfbny agXQRSzoSMOP3pJTunLF03h0mxmH3dJKeCiMBOY+JrQBwZA3gli/jLRX7dlwYHXn2iw4 Abtcrdu9HacIQ9y2CaUYOf9xPtZvg08lQkOyMQOWRVCWy72MV/H9+HHCB+41Yzys7Kf7 11Wsy0M3AMsZNaYTJ9G4Taa+LS/rfyxzUL9RRXK9lorOPZDPw+aHNRpeINvISf/VQuSD CiFQ== X-Gm-Message-State: AAQBX9cCirrPzbqw8RnhsrC3P4WMQsyJLHiQvK9R30LqIRSLTnNV5BJt 8M9pSxkIg5HORWYgpvjs0inboRrgZe5UAYizlApM6TS9HtAJnCA+dgwqGtHhvZVCGrrvwvTdg35 fKMVg0leR8q6B0OcnFuIhlj9ZutY3 X-Received: by 2002:a05:600c:22d6:b0:3eb:2da5:e19 with SMTP id 22-20020a05600c22d600b003eb2da50e19mr4612739wmg.27.1680694305744; Wed, 05 Apr 2023 04:31:45 -0700 (PDT) X-Google-Smtp-Source: AKy350bgJR+9jItxcQrvJsguKxNFfDjUdTz+JTjRLTm6qB71szWLKTQghclWZR4h05St1GZL+1Uwmg== X-Received: by 2002:a05:600c:22d6:b0:3eb:2da5:e19 with SMTP id 22-20020a05600c22d600b003eb2da50e19mr4612726wmg.27.1680694305488; Wed, 05 Apr 2023 04:31:45 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u13-20020a05600c210d00b003f0373d077csm1879783wml.47.2023.04.05.04.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:31:45 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development In-Reply-To: <20230404201842.567344-4-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-4-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:31:44 +0200 Message-ID: <87y1n6bm5b.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , Intel Graphics Development , Thomas Zimmermann , Daniel Vetter , Helge Deller Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Daniel Vetter writes: > Otherwise it's bit silly, and we might throw out the driver for the > screen the user is actually looking at. I haven't found a bug report > for this case yet, but we did get bug reports for the analog case > where we're throwing out the efifb driver. > > v2: Flip the check around to make it clear it's a special case for > kicking out the vgacon driver only (Thomas) > > References: https://bugzilla.kernel.org/show_bug.cgi?id=216303 > Signed-off-by: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aperture.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37051C76188 for ; Wed, 5 Apr 2023 11:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237443AbjDELcb (ORCPT ); Wed, 5 Apr 2023 07:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236486AbjDELca (ORCPT ); Wed, 5 Apr 2023 07:32:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2DC710D5 for ; Wed, 5 Apr 2023 04:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdvlAOB2HBtoxdSNuZT4WKN+Yt+RUmrcPHkXhNSXjuo=; b=V/utAZpsmJU6IGmd9W4JhGNlydEp2iZsBMhjGWS7jtrsCFgVeRLHvelWEFpmZALaDz+xse CyzEg64vrr/rEPSqndPJdkPQbvrkveDPon9InKiEcE9cfqs/CrGNIOhmDP6UCqu9I4D381 UIdweZfNjVgg+LLkee86DtPn2ukIm/8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-bPOyg5KiO0uvcwwMrZd23g-1; Wed, 05 Apr 2023 07:31:46 -0400 X-MC-Unique: bPOyg5KiO0uvcwwMrZd23g-1 Received: by mail-wm1-f71.google.com with SMTP id bi27-20020a05600c3d9b00b003ef6ee937b8so13812733wmb.2 for ; Wed, 05 Apr 2023 04:31:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694305; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DdvlAOB2HBtoxdSNuZT4WKN+Yt+RUmrcPHkXhNSXjuo=; b=G4F8SGbXm3bt6IZiAiPqQnVBlqUhFBj5xP7ZmXXqmQXpZkiBug+VVjxYGLqMbv9mlo z3Qn1KZgFA8q5pCtXaofloha5dLZgImAEGROLAzA2FVoqJ64oc/aeD4pNpk9vKGnS78n GBkcSQcpVOilTfsJhIYv6/eknI5R29uQyq+j9uYm80zI4jJ/PCLZ0DsHIb0Y/ts0y/S1 l1hu2vtkbDydvsvlU30Rtai3qXIwRX0g/hVQMNmnr6XzeBKxuMmMsWwp9SiLpBqthvwY FP5wR8slIjVERRO4XPBVt+GrjGY+d0gA808UGga46XxP1XzMxoD/CQv5D8ovO4xG8wN5 +Vhg== X-Gm-Message-State: AAQBX9e95Z2gm9DupeG4oWP9v/bBSkJkh8sGfhDnaTAqUHS5/eQgWDtg q2Dm9eIRCJPjfJb7n5ZtxgrVyR6T/astK6lydzmHXMMev2Bs18WlGreopGR7qrRAf3GyGFUJrib ETiE3HYDWhx1Hjiqfk29CI14= X-Received: by 2002:a05:600c:22d6:b0:3eb:2da5:e19 with SMTP id 22-20020a05600c22d600b003eb2da50e19mr4612741wmg.27.1680694305744; Wed, 05 Apr 2023 04:31:45 -0700 (PDT) X-Google-Smtp-Source: AKy350bgJR+9jItxcQrvJsguKxNFfDjUdTz+JTjRLTm6qB71szWLKTQghclWZR4h05St1GZL+1Uwmg== X-Received: by 2002:a05:600c:22d6:b0:3eb:2da5:e19 with SMTP id 22-20020a05600c22d600b003eb2da50e19mr4612726wmg.27.1680694305488; Wed, 05 Apr 2023 04:31:45 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u13-20020a05600c210d00b003f0373d077csm1879783wml.47.2023.04.05.04.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:31:45 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development Cc: Intel Graphics Development , Daniel Vetter , Daniel Vetter , Thomas Zimmermann , Helge Deller , linux-fbdev@vger.kernel.org Subject: Re: [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga In-Reply-To: <20230404201842.567344-4-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-4-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:31:44 +0200 Message-ID: <87y1n6bm5b.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Daniel Vetter writes: > Otherwise it's bit silly, and we might throw out the driver for the > screen the user is actually looking at. I haven't found a bug report > for this case yet, but we did get bug reports for the analog case > where we're throwing out the efifb driver. > > v2: Flip the check around to make it clear it's a special case for > kicking out the vgacon driver only (Thomas) > > References: https://bugzilla.kernel.org/show_bug.cgi?id=216303 > Signed-off-by: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aperture.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8E89C76188 for ; Wed, 5 Apr 2023 11:31:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA75710E8EF; Wed, 5 Apr 2023 11:31:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3FC710E8EF for ; Wed, 5 Apr 2023 11:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680694308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdvlAOB2HBtoxdSNuZT4WKN+Yt+RUmrcPHkXhNSXjuo=; b=g8WdMuY81EJmL5GZxq9i3ONAMJU+dwkuBob3u2BD66IPTpyzERouTJzVugQ7D8pRR/hjRz 1NOJcF9uiQq7v6hRR/sVXorGQxpHKLDJLOPXxPwerHfQPLWDp2Lzyu7zW2ra9MZ5rj08mo UZ1dlmcIFgZn4BtXN+xVq+Csaqzm3OM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-LZFl6N2TMUKX4tdtQ5dw_w-1; Wed, 05 Apr 2023 07:31:46 -0400 X-MC-Unique: LZFl6N2TMUKX4tdtQ5dw_w-1 Received: by mail-wm1-f72.google.com with SMTP id l16-20020a05600c4f1000b003ef6ed5f645so13996659wmq.9 for ; Wed, 05 Apr 2023 04:31:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680694305; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DdvlAOB2HBtoxdSNuZT4WKN+Yt+RUmrcPHkXhNSXjuo=; b=Y2vJLlxX8UT+fAfDfBLJV95zPGAhDE10ILalsp4+H0kF718g+43BdChAndpaEU9sZo F812rOgWyJ4dJt7oNyccCCStGdlBd2VgjcV9WMx2DfCmqtqqkEUlPp0z39sxjj6k/7VO +C0unqKHz6AVI/N9bBYEnR/MpYNi9QXTMfzh+oLqQ55LMRIKf0PmbuSiJxr7/JjZzbbR GATxDdoRAktoIH353ivIKWL9hCiKdYpVur7Bs5Z6qAl/HXRCeoiQsp8bbs2MCzGiGHL4 X5UkTqZVbiIy4Vop4tJNaRpcL1Sn3f1lz0T0ZcFn3xF39niJrdYtxsGr7UD7IUjIseKy 9rOg== X-Gm-Message-State: AAQBX9dov6RFfLo5DKucW/Jg7WXrRRiQjYZvm8usPANSspH/qfx6lYoR gOOW2KEZ5YiplTlNhFNQSeAT/lFKXQMjlD4ovSuuCA2HCwQMxKffOvXk424H3j/n422iRaib9QR /YObkcdUuG668Yhka3JDNCIbT5Pwj X-Received: by 2002:a05:600c:22d6:b0:3eb:2da5:e19 with SMTP id 22-20020a05600c22d600b003eb2da50e19mr4612740wmg.27.1680694305744; Wed, 05 Apr 2023 04:31:45 -0700 (PDT) X-Google-Smtp-Source: AKy350bgJR+9jItxcQrvJsguKxNFfDjUdTz+JTjRLTm6qB71szWLKTQghclWZR4h05St1GZL+1Uwmg== X-Received: by 2002:a05:600c:22d6:b0:3eb:2da5:e19 with SMTP id 22-20020a05600c22d600b003eb2da50e19mr4612726wmg.27.1680694305488; Wed, 05 Apr 2023 04:31:45 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u13-20020a05600c210d00b003f0373d077csm1879783wml.47.2023.04.05.04.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:31:45 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development Subject: Re: [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga In-Reply-To: <20230404201842.567344-4-daniel.vetter@ffwll.ch> References: <20230404201842.567344-1-daniel.vetter@ffwll.ch> <20230404201842.567344-4-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 13:31:44 +0200 Message-ID: <87y1n6bm5b.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , Intel Graphics Development , Thomas Zimmermann , Daniel Vetter , Helge Deller Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Daniel Vetter writes: > Otherwise it's bit silly, and we might throw out the driver for the > screen the user is actually looking at. I haven't found a bug report > for this case yet, but we did get bug reports for the analog case > where we're throwing out the efifb driver. > > v2: Flip the check around to make it clear it's a special case for > kicking out the vgacon driver only (Thomas) > > References: https://bugzilla.kernel.org/show_bug.cgi?id=216303 > Signed-off-by: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Javier Martinez Canillas > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/aperture.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat