From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A44F9C61DA4 for ; Thu, 16 Feb 2023 05:47:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01DEA10E12A; Thu, 16 Feb 2023 05:47:02 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36CC810E12A for ; Thu, 16 Feb 2023 05:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676526420; x=1708062420; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=NjDMF+81QlFotEi8S4GH9qPz3hgEZd/IcE+MuNQb4i0=; b=HUN+/CkvH6lmNP8wPB7kC36CeEfr9pcb5z8pODFT/3/RpvFE9S3wX/RW bZA09L01imfszI1bhpJ2HMXpdCOOVUsZoxYNKuQMz0eYgGM5b7gH6ENpR Dqygq0q1T9zkJng0hL8t3HledCT132VQJt0XTgqN8nBjn00nb3MknLN3e SHjBbedjZh6f8Llo7Y53k1P518HkSjclxtmVkbPAaYC58Bogr9ANBEBtb ZZWUnd6u+OvCaKv+zBrqOwjsQ4PZETxzxIxGx6qEwrv75oIH/e+uG3ps5 Smtj32atVM3C53mtlhG++YD5NviLVHEEOfNkVik4IanJi6U+XSCQSkfUI g==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="359059858" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="359059858" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 21:46:59 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="738715646" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="738715646" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.251.28.186]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 21:46:59 -0800 Date: Wed, 15 Feb 2023 21:36:50 -0800 Message-ID: <87y1oymarx.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <87zg9emc2s.wl-ashutosh.dixit@intel.com> References: <20230215005419.2100887-1-umesh.nerlige.ramappa@intel.com> <20230215005419.2100887-4-umesh.nerlige.ramappa@intel.com> <87zg9emc2s.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lionel G Landwerlin , intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: > > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > > > Validate the OA sseu config after all params are parsed. > > Commit messages for all patches need to answer the "why" or the reason for > the patch. In this case maybe an overkill but probably something like: > > Validate the OA sseu config after all params are parsed since the engine > can be passed in as part of perf properties. Also, if we do this the patch should probably be later in the series after the patch which introduces engine class/instance in the perf properties.