All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: buildroot@busybox.net, Sergey Matyukevich <geomatsi@gmail.com>
Subject: Re: [Buildroot] [PATCH] boot/arm-trusted-firmware: fix SSP disable in v2.2
Date: Tue, 15 Nov 2022 14:10:18 +0100	[thread overview]
Message-ID: <87y1scfjnp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <a165e1785fec7f9b4ce3e38f1282c5ab87bff511.1668366594.git.baruch@tkos.co.il> (Baruch Siach via buildroot's message of "Sun, 13 Nov 2022 21:09:54 +0200")

>>>>> "Baruch" == Baruch Siach via buildroot <buildroot@buildroot.org> writes:

 > ATF version 2.2 and older does not disable SSP when
 > ENABLE_STACK_PROTECTOR is not set. This is because the compiler enables
 > SSP by default, and ATF does not pass -fno-stack-protector to the
 > compiler. Upstream commit 7af195e29a42 ("Disable stack protection
 > explicitly") fixed the issue for v2.3 and newer.

 > Add -fno-stack-protector in CFLAGS when
 > BR2_TARGET_ARM_TRUSTED_FIRMWARE_SSP is not set to fix older ATF
 > versions.

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/3301821171

 > Cc: Dick Olsson <hi@senzilla.io>
 > Cc: Sergey Matyukevich <geomatsi@gmail.com>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed to 2022.08.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-11-15 13:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 19:09 [Buildroot] [PATCH] boot/arm-trusted-firmware: fix SSP disable in v2.2 Baruch Siach via buildroot
2022-11-13 20:55 ` Thomas Petazzoni via buildroot
2022-11-15 13:10 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1scfjnp.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=geomatsi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.