From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9965DC4332F for ; Sat, 12 Nov 2022 14:11:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CBDEF15E0; Sat, 12 Nov 2022 15:10:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CBDEF15E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1668262282; bh=/4JKZtcckJ/2ISECVr45OWmjtgy3O7suUBqc1H/tiZc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UEmj5doLXtKLQB700u62kGyKqCt3RUrXENZajgIqQo5mfK5j0OFBnMCdN8qUW9HRu hAk4qWcZByVcE7vdLfNaIVWvtPXNNdqXiod5g1oW9glgdtjxYUvrTP5Ts9y0istLOm M8/nOz9wMvSr+IAZcr4YulOlK4gj43wAnYM5IRkk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6A43EF800CC; Sat, 12 Nov 2022 15:10:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 109D0F800CC; Sat, 12 Nov 2022 15:10:30 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E0013F800CC; Sat, 12 Nov 2022 15:10:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E0013F800CC Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="FmgSE1Dd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wmtJ+VSo" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 246651F88F; Sat, 12 Nov 2022 14:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668262222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hca6nGOkQBaZe/UUSAuQCCX33sld7xfAXwjJspBu2ps=; b=FmgSE1DdPkgqkbE/WKVEO13epavsK8qIrF74k2iIOFvcYwVSUEjtRlek4n0dbNMNR1Tttq Nq1NZ4FBt8q815w9VSZOu1DAG57kDLLesY43jO+b4YfArSHszY7PN53YYIOHZ8ZHGWRpjh oOcGm5LXUyA/su6VPDNKHajHry6rxN8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668262222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hca6nGOkQBaZe/UUSAuQCCX33sld7xfAXwjJspBu2ps=; b=wmtJ+VSoIp7jxdA1W6zxwn4E6Q4gG3BT0/6gBY1iBjW3b1boGU1p6zKy4PvY+BTi6iUICE zqxHHAnq4WnJCQDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1B7313A08; Sat, 12 Nov 2022 14:10:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OaeMNk2pb2PGLAAAMHmgww (envelope-from ); Sat, 12 Nov 2022 14:10:21 +0000 Date: Sat, 12 Nov 2022 15:10:21 +0100 Message-ID: <87y1sg1cxe.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Subject: Re: [syzbot] WARNING in snd_usbmidi_output_open In-Reply-To: References: <000000000000734a7305ed3608ba@google.com> <00000000000073937205ed45fe5c@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, rafael@kernel.org, gregkh@linuxfoundation.org, tiwai@suse.com, clemens@ladisch.de, lgirdwood@gmail.com, alsa-devel-owner@alsa-project.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot , peda@axentia.se X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 12 Nov 2022 14:35:06 +0100, Mark Brown wrote: > > On Sat, Nov 12, 2022 at 05:29:21AM -0800, syzbot wrote: > > syzbot has bisected this issue to: > > > > commit 4f8ed19593872b710f27bbc3b7a9ce03310efc57 > > Author: Mark Brown > > Date: Thu Jun 2 13:10:58 2022 +0000 > > > > ASoC: tfa9879: Use modern ASoC DAI format terminology > > This bisection really doesn't seem credible for an issue in a different > driver... The tfa9879 is neither a USB nor MIDI device, and the commit > in question is a stylistic update. Yes, the bisection result is bogus. And, the problem here is just a kernel WARNING produced by snd_BUG_ON() macro usage, and the check itself is valid. We just need to drop snd_BUG_ON() wrapping. Will submit the fix later. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611C3C4332F for ; Sat, 12 Nov 2022 14:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234762AbiKLOK1 (ORCPT ); Sat, 12 Nov 2022 09:10:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiKLOKY (ORCPT ); Sat, 12 Nov 2022 09:10:24 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C52CF5A2 for ; Sat, 12 Nov 2022 06:10:23 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 246651F88F; Sat, 12 Nov 2022 14:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668262222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hca6nGOkQBaZe/UUSAuQCCX33sld7xfAXwjJspBu2ps=; b=FmgSE1DdPkgqkbE/WKVEO13epavsK8qIrF74k2iIOFvcYwVSUEjtRlek4n0dbNMNR1Tttq Nq1NZ4FBt8q815w9VSZOu1DAG57kDLLesY43jO+b4YfArSHszY7PN53YYIOHZ8ZHGWRpjh oOcGm5LXUyA/su6VPDNKHajHry6rxN8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668262222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hca6nGOkQBaZe/UUSAuQCCX33sld7xfAXwjJspBu2ps=; b=wmtJ+VSoIp7jxdA1W6zxwn4E6Q4gG3BT0/6gBY1iBjW3b1boGU1p6zKy4PvY+BTi6iUICE zqxHHAnq4WnJCQDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1B7313A08; Sat, 12 Nov 2022 14:10:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OaeMNk2pb2PGLAAAMHmgww (envelope-from ); Sat, 12 Nov 2022 14:10:21 +0000 Date: Sat, 12 Nov 2022 15:10:21 +0100 Message-ID: <87y1sg1cxe.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: syzbot , alsa-devel-owner@alsa-project.org, alsa-devel@alsa-project.org, clemens@ladisch.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, peda@axentia.se, perex@perex.cz, rafael@kernel.org, syzkaller-bugs@googlegroups.com, tiwai@suse.com Subject: Re: [syzbot] WARNING in snd_usbmidi_output_open In-Reply-To: References: <000000000000734a7305ed3608ba@google.com> <00000000000073937205ed45fe5c@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Nov 2022 14:35:06 +0100, Mark Brown wrote: > > On Sat, Nov 12, 2022 at 05:29:21AM -0800, syzbot wrote: > > syzbot has bisected this issue to: > > > > commit 4f8ed19593872b710f27bbc3b7a9ce03310efc57 > > Author: Mark Brown > > Date: Thu Jun 2 13:10:58 2022 +0000 > > > > ASoC: tfa9879: Use modern ASoC DAI format terminology > > This bisection really doesn't seem credible for an issue in a different > driver... The tfa9879 is neither a USB nor MIDI device, and the commit > in question is a stylistic update. Yes, the bisection result is bogus. And, the problem here is just a kernel WARNING produced by snd_BUG_ON() macro usage, and the check itself is valid. We just need to drop snd_BUG_ON() wrapping. Will submit the fix later. thanks, Takashi