From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: tps6507x-ts: remove variable loops
Date: Fri, 21 Oct 2022 15:04:39 +0200 [thread overview]
Message-ID: <87y1t9pbtk.fsf@baylibre.com> (raw)
In-Reply-To: <20221020181642.24417-1-colin.i.king@gmail.com>
On Thu, Oct 20, 2022 at 19:16, Colin Ian King <colin.i.king@gmail.com> wrote:
> The variable loops is being incremented but is never referenced,
> it is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/input/touchscreen/tps6507x-ts.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 357a3108f2e5..f48871767763 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc,
> static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
> {
> s32 ret;
> - s32 loops = 0;
> u8 val;
>
> ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG,
> @@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
> ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val);
> if (ret)
> return ret;
> - loops++;
> }
>
> return ret;
> --
> 2.37.3
next prev parent reply other threads:[~2022-10-21 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 18:16 [PATCH] Input: tps6507x-ts: remove variable loops Colin Ian King
2022-10-21 13:04 ` Mattijs Korpershoek [this message]
2022-10-24 11:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1t9pbtk.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=colin.i.king@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.