Re: [PATCH v2 4/7] configure: don't enable cross compilers unless in target_list

["Alex Bennée" <alex.bennee@linaro.org>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 10/13/22 21:48, Alex Bennée wrote:
>>> +  case " $target_list " in
>>> +    " $1 ") ;;
>>> +    *) return 1 ;;
>>> +  esac
>>> +
>> this of course prevents building of roms by actually disabling all
>> target compilers...
>
> Yeah, two asterisks are missing.  I'll send out a proper patch.

I tried this:

@@ -1866,6 +1866,15 @@ probe_target_compiler() {
   container_cross_ranlib=
   container_cross_strip=
 
+  # We shall skip configuring the target compiler if the user didn't
+  # bother enabling an appropriate guest. This avoids building
+  # extraneous firmware images and tests.
+  if test "${target_list#*$1}" != "$1"; then
+      break;
+  else
+      return 1
+  fi
+
   target_arch=${1%%-*}
   case $target_arch in
     aarch64) container_hosts="x86_64 aarch64" ;;

>
> Paolo


-- 
Alex Bennée