Re: [PATCH v3] staging: r8188eu: fix too many leading tabs

[Joash Naidoo <joash.n09@gmail.com>]

Greg KH <gregkh@linuxfoundation.org> writes:

> On Mon, Sep 19, 2022 at 03:23:10PM +0200, Joash Naidoo wrote:
>> Coding style fix. Fix too many leading tabs and line length.
>>
>> Signed-off-by: Joash Naidoo <joash.n09@gmail.com>
>> ---
>> Changes in v3:
>>     - Fix flipped condition mistake
>>     - move skb NULL check before dereferencing it
>> Changes in v2:
>>     - Flip additional nested if conditions and don't reverse 
>>     the last if statement
>>     - Move declarations to start of function
>>     - Separate converting __constant_htons to htons to another 
>>     patch
>
> Always test-build your changes before sending them out so you do 
> not get
> grumpy emails from maintainers asking why you didn't test-build 
> your
> changes...
>
> thanks,
>
> greg k-h
Hi Greg,

Indeed building and testing is a vital step before sending
changes. Is this message referring to my V3 patch not building? Or
referring to my earlier versions?

Before sending I built my changes with:

make M=drivers/staging/r8188eu clean
make M=drivers/staging/r8188eu

I have a TP-Link Wifi dongle (Model: TL-WN725N) which I used to
test. I enabled the driver as module with make menuconfig, built,
installed (make modules_install && make install) and booted the
modified kernel image (vmlinuz-6.0.0-rc5+). Then I  ensured my
wpa_supplicant service runs fine and then just checked if I could
still connect to Wifi and browse the web. (I understand this is
limited, since I didn't catch my error in V2) Furthermore, I also
ran:

dmesg -t -l crit
dmesg -t -l warn
dmesg -t -l err

I have only gotten the following relevant warning:

r8188eu: module is from the staging directory, the quality is
unknown, you have been warned.

If there is anything I still may be lacking, please advise. Thank
you for your support.

Kind Regards,
Joash