From: Punit Agrawal <punit.agrawal@bytedance.com>
To: Perry Yuan <Perry.Yuan@amd.com>
Cc: <rafael.j.wysocki@intel.com>, <ray.huang@amd.com>,
<viresh.kumar@linaro.org>, <Deepak.Sharma@amd.com>,
<Mario.Limonciello@amd.com>, <Nathan.Fontenot@amd.com>,
<Alexander.Deucher@amd.com>, <Jinzhou.Su@amd.com>,
<Shimmer.Huang@amd.com>, <Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration
Date: Thu, 01 Sep 2022 15:55:27 +0100 [thread overview]
Message-ID: <87y1v3cffk.fsf@stealth> (raw)
In-Reply-To: <20220901062339.2357552-1-Perry.Yuan@amd.com> (Perry Yuan's message of "Thu, 1 Sep 2022 14:23:39 +0800")
Hi Perry,
Perry Yuan <Perry.Yuan@amd.com> writes:
> Cleanup the headers declaration which are not used
> actually and some duplicated declaration which is declarated in some
> other headers already, it will help to simplify the header part.
>
> Reviewed-by: Huang Rui <ray.huang@amd.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9ac75c1cde9c..9cf7bc162e7c 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -31,19 +31,15 @@
> #include <linux/compiler.h>
> #include <linux/dmi.h>
> #include <linux/slab.h>
> -#include <linux/acpi.h>
> #include <linux/io.h>
> #include <linux/delay.h>
> #include <linux/uaccess.h>
> #include <linux/static_call.h>
>
> -#include <acpi/processor.h>
> #include <acpi/cppc_acpi.h>
>
> #include <asm/msr.h>
> #include <asm/processor.h>
> -#include <asm/cpufeature.h>
> -#include <asm/cpu_device_id.h>
> #include "amd-pstate-trace.h"
>
> #define AMD_PSTATE_TRANSITION_LATENCY 0x20000
The patch has the same issue as mentioned in the previous version.
Please don't remove any header includes whose definitions are directly
used in amd-pstate.c. Look at example from my previous comment.
prev parent reply other threads:[~2022-09-01 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 6:23 [PATCH v6] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration Perry Yuan
2022-09-01 6:31 ` Viresh Kumar
2022-09-01 6:56 ` Yuan, Perry
2022-09-01 7:00 ` Viresh Kumar
2022-09-01 14:55 ` Punit Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1v3cffk.fsf@stealth \
--to=punit.agrawal@bytedance.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.