From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3CA8C433EF for ; Thu, 21 Jul 2022 03:24:10 +0000 (UTC) Received: from localhost ([::1]:58602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEMnJ-0006h1-LU for qemu-devel@archiver.kernel.org; Wed, 20 Jul 2022 23:24:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEMmh-00061b-BN for qemu-devel@nongnu.org; Wed, 20 Jul 2022 23:23:31 -0400 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:58877) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEMme-0002Yv-7s for qemu-devel@nongnu.org; Wed, 20 Jul 2022 23:23:30 -0400 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id 399E410A42B; Thu, 21 Jul 2022 12:23:22 +0900 (JST) Received: from SIOS1075.ysato.ml (ae227146.dynamic.ppp.asahi-net.or.jp [14.3.227.146]) by sakura.ysato.name (Postfix) with ESMTPSA id 56AE71C008D; Thu, 21 Jul 2022 12:23:22 +0900 (JST) Date: Thu, 21 Jul 2022 12:23:22 +0900 Message-ID: <87y1wnqhcl.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: "Jason A. Donenfeld" Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] hw/rx: pass random seed to fdt In-Reply-To: <20220719122033.135902-1-Jason@zx2c4.com> References: <20220719122033.135902-1-Jason@zx2c4.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.13; envelope-from=ysato@users.sourceforge.jp; helo=mail01.asahi-net.or.jp X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 19 Jul 2022 21:20:33 +0900, Jason A. Donenfeld wrote: > > If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to > initialize early. Set this using the usual guest random number > generation function. This FDT node is part of the DT specification. > > Cc: Yoshinori Sato > Signed-off-by: Jason A. Donenfeld > --- > hw/rx/rx-gdbsim.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c > index be147b4bd9..8ffe1b8035 100644 > --- a/hw/rx/rx-gdbsim.c > +++ b/hw/rx/rx-gdbsim.c > @@ -19,6 +19,7 @@ > #include "qemu/osdep.h" > #include "qemu/cutils.h" > #include "qemu/error-report.h" > +#include "qemu/guest-random.h" > #include "qapi/error.h" > #include "hw/loader.h" > #include "hw/rx/rx62n.h" > @@ -83,6 +84,7 @@ static void rx_gdbsim_init(MachineState *machine) > MemoryRegion *sysmem = get_system_memory(); > const char *kernel_filename = machine->kernel_filename; > const char *dtb_filename = machine->dtb; > + uint8_t rng_seed[32]; > > if (machine->ram_size < mc->default_ram_size) { > char *sz = size_to_str(mc->default_ram_size); > @@ -140,6 +142,8 @@ static void rx_gdbsim_init(MachineState *machine) > error_report("Couldn't set /chosen/bootargs"); > exit(1); > } > + qemu_guest_getrandom_nofail(rng_seed, sizeof(rng_seed)); > + qemu_fdt_setprop(dtb, "/chosen", "rng-seed", rng_seed, sizeof(rng_seed)); > /* DTB is located at the end of SDRAM space. */ > dtb_offset = ROUND_DOWN(machine->ram_size - dtb_size, 16); > rom_add_blob_fixed("dtb", dtb, dtb_size, > -- > 2.35.1 > Reviewed-by: Yoshinori Sato -- Yosinori Sato