From: Richard Palethorpe <rpalethorpe@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] mount03: Convert to new API
Date: Mon, 18 Jul 2022 08:14:23 +0100 [thread overview]
Message-ID: <87y1wqj2yh.fsf@suse.de> (raw)
In-Reply-To: <YtGZZeUm2iB/uySr@pevik>
Hello Petr,
Petr Vorel <pvorel@suse.cz> writes:
> Hi Chen,
>
> quite nice work, but more cleanup is needed.
>
>> testcases/kernel/syscalls/mount/mount03.c | 462 ++++++++--------------
> ...
>> #define FILE_MODE (S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH)
>> -#define DIR_MODE (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP| \
>> - S_IXGRP|S_IROTH|S_IXOTH)
>> #define SUID_MODE (S_ISUID|S_IRUSR|S_IXUSR|S_IXGRP|S_IXOTH)
>
> @Richie @Li @Metan: There are checkpatch.pl warnings. Yes, kernel folks does not
> like permission warnings. Do we want to follow? Or should we remove these from
> our checkpatch.pl fork (we use constants in many places)?
I'm not sure about the rule. However there is no reason we can't follow
it for new tests. We don't want to have arbitrary style differences
between LTP and the kernel.
Some rules don't make sense in userland for technical reasons, but this
one is purely about readability.
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-07-18 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 6:25 [LTP] [PATCH] mount03: Convert to new API chenhx.fnst
2022-07-15 16:44 ` Petr Vorel
2022-07-18 7:14 ` Richard Palethorpe [this message]
2022-07-18 7:52 ` Cyril Hrubis
2022-07-25 8:52 ` Petr Vorel
2022-08-16 9:53 ` xuyang2018.jy
2022-07-26 6:12 ` [LTP] 回复: " chenhx.fnst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1wqj2yh.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.