From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5BCC433F5 for ; Tue, 17 May 2022 19:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343897AbiEQT5P (ORCPT ); Tue, 17 May 2022 15:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347718AbiEQT5N (ORCPT ); Tue, 17 May 2022 15:57:13 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6C5C522C2 for ; Tue, 17 May 2022 12:57:10 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 594B31F4404A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652817428; bh=OWXF6pN1PKCgd1hX+us24uD4Px7KYa/a9N/AE+rwvM4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MNzP6OhNLXZ5yDXAQu5rueURwO2Uxu1GS86MzOjPufuvaNR9Q7nnkzH0RcByRFwAL XMfTwYuZ7UM3DgKVUwqlWcNvFs/vrPrzssPlBcjIY11866UwSxMHJcETkHJH+cwYcW MNBqilZDb+k5CZqGqVFjGwQRbY7EQ9QOEC0gjUB1t8her9T3p0PusulQScw8ffCHud bmEsilcAsOBVfaMoKtmtZ8Wk1eD7UCX8dKX9s2UNiqAN52rb00tWSPEO4tOkI8r61u qMfna+TLKoTGVPqOJJ/HP/1rP/wdwIrilQhv7AIKTYuOFPgxOnv5HFyy0gza8edrTi q1AadYCLotVbA== From: Gabriel Krisman Bertazi To: "Theodore Ts'o" Cc: adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org, kernel@collabora.com Subject: Re: [PATCH v4 00/10] Clean up the case-insensitive lookup path Organization: Collabora References: <20220511193146.27526-1-krisman@collabora.com> Date: Tue, 17 May 2022 15:57:05 -0400 In-Reply-To: (Theodore Ts'o's message of "Tue, 17 May 2022 15:37:48 -0400") Message-ID: <87y1z0vsoe.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org "Theodore Ts'o" writes: > On Wed, May 11, 2022 at 03:31:36PM -0400, Gabriel Krisman Bertazi wrote: >> The case-insensitive implementations in f2fs and ext4 have quite a bit >> of duplicated code. This series simplifies the ext4 version, with the >> goal of extracting ext4_ci_compare into a helper library that can be >> used by both filesystems. It also reduces the clutter from many >> codeguards for CONFIG_UNICODE; as requested by Linus, they are part of >> the codeflow now. >> >> While there, I noticed we can leverage the utf8 functions to detect >> encoded names that are corrupted in the filesystem. Therefore, it also >> adds an ext4 error on that scenario, to mark the filesystem as >> corrupted. > > Gabriel, are you planning on doing another version of this patch > series? > It looks like the first two patches for ext4 are not controversial, so > I could take those, while some of the other patches have questions > which Eric has raised. Hi Ted, I'll be reworking the series to apply Eric's comments and I might render patch 1 unnecessary. I'd be happy to send a v5 for the whole thing instead of applying the first two now. Thanks, -- Gabriel Krisman Bertazi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4171C433EF for ; Tue, 17 May 2022 19:57:30 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nr3Jw-000875-Su; Tue, 17 May 2022 19:57:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nr3Jt-00086z-M0 for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 May 2022 19:57:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8/+x3vzbrMNcnz1n+GLFzwNBAsTVFdJPfgK2PM6XggE=; b=SwMhlq6fIKwwclEmsijzEj+E/C HFeiCHAzB57BGDXm9ynDIOU9HIHl5olVYfLZmvX3cEPPeenuXTh/sWiw/VicHYmMOtLa3rAl4HgIg A8uJTw4px+bq/hXUI+JASMrNsAvEx1VCaP332tPrFviNvqnJbsYa1hVfYznzaUTyjFps=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8/+x3vzbrMNcnz1n+GLFzwNBAsTVFdJPfgK2PM6XggE=; b=K27W/ql6xRmPCEORjGu77SGmrg KrH4/jjLUtO+lL5bTTeuyV2wmvLIaoGTQbOjIM2xj5NWVciDDWpHahIlMFAS3xFtN0uKfHTz7/IoE l5MdumX3VDXTGgmxIdgxiEYjNqpyQIUryFocswuSwmxhqbvdcm3lWmVR2OiNyRnBQ2lI=; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nr3Jr-0007zq-Gn for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 May 2022 19:57:24 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 594B31F4404A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652817428; bh=OWXF6pN1PKCgd1hX+us24uD4Px7KYa/a9N/AE+rwvM4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MNzP6OhNLXZ5yDXAQu5rueURwO2Uxu1GS86MzOjPufuvaNR9Q7nnkzH0RcByRFwAL XMfTwYuZ7UM3DgKVUwqlWcNvFs/vrPrzssPlBcjIY11866UwSxMHJcETkHJH+cwYcW MNBqilZDb+k5CZqGqVFjGwQRbY7EQ9QOEC0gjUB1t8her9T3p0PusulQScw8ffCHud bmEsilcAsOBVfaMoKtmtZ8Wk1eD7UCX8dKX9s2UNiqAN52rb00tWSPEO4tOkI8r61u qMfna+TLKoTGVPqOJJ/HP/1rP/wdwIrilQhv7AIKTYuOFPgxOnv5HFyy0gza8edrTi q1AadYCLotVbA== From: Gabriel Krisman Bertazi To: "Theodore Ts'o" Organization: Collabora References: <20220511193146.27526-1-krisman@collabora.com> Date: Tue, 17 May 2022 15:57:05 -0400 In-Reply-To: (Theodore Ts'o's message of "Tue, 17 May 2022 15:37:48 -0400") Message-ID: <87y1z0vsoe.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1nr3Jr-0007zq-Gn Subject: Re: [f2fs-dev] [PATCH v4 00/10] Clean up the case-insensitive lookup path X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org, adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net "Theodore Ts'o" writes: > On Wed, May 11, 2022 at 03:31:36PM -0400, Gabriel Krisman Bertazi wrote: >> The case-insensitive implementations in f2fs and ext4 have quite a bit >> of duplicated code. This series simplifies the ext4 version, with the >> goal of extracting ext4_ci_compare into a helper library that can be >> used by both filesystems. It also reduces the clutter from many >> codeguards for CONFIG_UNICODE; as requested by Linus, they are part of >> the codeflow now. >> >> While there, I noticed we can leverage the utf8 functions to detect >> encoded names that are corrupted in the filesystem. Therefore, it also >> adds an ext4 error on that scenario, to mark the filesystem as >> corrupted. > > Gabriel, are you planning on doing another version of this patch > series? > It looks like the first two patches for ext4 are not controversial, so > I could take those, while some of the other patches have questions > which Eric has raised. Hi Ted, I'll be reworking the series to apply Eric's comments and I might render patch 1 unnecessary. I'd be happy to send a v5 for the whole thing instead of applying the first two now. Thanks, -- Gabriel Krisman Bertazi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel