From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib: Add missing newline in igt_fopen_data's logging
Date: Fri, 13 May 2022 08:24:13 -0700 [thread overview]
Message-ID: <87y1z55uci.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220513095300.6785-1-petri.latvala@intel.com>
On Fri, 13 May 2022 02:53:00 -0700, Petri Latvala wrote:
>
> Also drive-by, change %s strerror(errno) to the equivalent %m.
Hmm didn't know about this one :)
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
> lib/igt_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 6dad3c84..ba906ab0 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -2929,8 +2929,7 @@ FILE *__igt_fopen_data(const char* igt_srcdir, const char* igt_datadir,
> }
>
> if (!fp)
> - igt_critical("Could not open data file \"%s\": %s", filename,
> - strerror(errno));
> + igt_critical("Could not open data file \"%s\": %m\n", filename);
>
> return fp;
> }
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-05-13 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 9:53 [igt-dev] [PATCH i-g-t] lib: Add missing newline in igt_fopen_data's logging Petri Latvala
2022-05-13 11:44 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-05-13 13:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-16 9:13 ` Petri Latvala
2022-05-13 15:24 ` Dixit, Ashutosh [this message]
2022-05-16 16:21 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1z55uci.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.