From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0760C433F5 for ; Wed, 27 Apr 2022 21:10:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2F91349E45; Wed, 27 Apr 2022 17:10:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Z7JmMFPFmlC; Wed, 27 Apr 2022 17:10:08 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D50B14B1B6; Wed, 27 Apr 2022 17:10:08 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B1E2E49E45 for ; Wed, 27 Apr 2022 17:10:07 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SBukKEiH1bXS for ; Wed, 27 Apr 2022 17:10:06 -0400 (EDT) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A0D2149DED for ; Wed, 27 Apr 2022 17:10:06 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 22BFDB82AD2; Wed, 27 Apr 2022 21:10:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1E93C385A7; Wed, 27 Apr 2022 21:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651093803; bh=12d6/CBzd02oZvju7Qb4kipcwNr/RTQQkKKMy0Kf12g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=twwMhuUM80iWBGPxpkH6nihQbKdGbY8ApqTOdU9m3p7gW4vXcLj+Nr2ypQMqPy2W2 rV72B33XDzC/nevkPH5MUV8x8P7r+UAoThbsyGEYzJAIV+NKp3cgg+THJjQJLupPg2 k+ZtpnDcIj1YEjmYVH8AN9EHlBiKzP9h8gJ8zzrX8jbwgS538/qMPU2gYs2//i1vNY JO+/Graaii7w6EhWj3VkNFc1KFXlWRcw/S9wDncsD08nBe1Nqr7KAZvuN/rMPxlUF0 TuJvPYhgm4FfB/TvrNa0QXTnrUuJNR/2/qGQDGGE7jJmWlZsLWgrhL6BfsAPTMsYLv imqE6HD+7yNLw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1njovB-007Tda-95; Wed, 27 Apr 2022 22:10:01 +0100 Date: Wed, 27 Apr 2022 22:10:01 +0100 Message-ID: <87y1zq8c7q.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH] KVM/arm64: Don't emulate a PMU for 32-bit guests if feature not set In-Reply-To: References: <20220425145530.723858-1-alexandru.elisei@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, oupton@google.com, james.morse@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, 27 Apr 2022 10:45:39 +0100, Alexandru Elisei wrote: > > Hi, > > On Wed, Apr 27, 2022 at 12:57:57AM -0700, Oliver Upton wrote: > > Hi Alex, > > > > Seems to me all the AArch32 feature register trap logic should come > > later on as there's a nonzero chance I introduced a bug :) Shall we > > stop the bleeding w/ your originally proposed patch? Doesn't seem any > > more objectionable than what we're already doing. > > I am leaning towards merging this patch to prevent people from seeing the > splat, and when the AArch32 ID reg series gets merged it can be reverted. > But in the end it's up to Marc to decide what he prefers. Yeah, I'd like to plug this ASAP. I'll queue the workaround for 5.18, and we can rework that the proper way for 5.19. Thanks to both for working on it together, much appreciated. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF3EBC433F5 for ; Wed, 27 Apr 2022 21:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3vdAvpoQynm5V4JiBwPnUIWquCgewJEkdjvzTFy4N68=; b=DCmKpFi3oi83RT pLWLYgn5qxdV6R+z6lc4zTx6lF7AOgOk9RT9Tk+oOLIoY+vrWeLSXzr3Gx0Z4j/datho6SvocBL4W RurDjzHMnFXAySkTvM382N4BeZZT7Fua2tfy85Wdnq1NvTGNrTaS/pikPtt+Did5CfpvtbLYL/suZ e6U6QVcrURxcyNSPxmk8xpqvPUqsS6rPjpo+5mtBmveDpo/X02Mfy6GeS3euMJ0V1IggX7jy37EwG Dn1y+NRFHuGoZce3+lWAToQc9YDboIcHyUqVIFqglejvaoqqa6+s05umgcIjsUbRhaDglESIYcTTx O/TW008u6OJAMl1K1+sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njovL-003arP-41; Wed, 27 Apr 2022 21:10:11 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njovI-003aqn-AC for linux-arm-kernel@lists.infradead.org; Wed, 27 Apr 2022 21:10:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 22BFDB82AD2; Wed, 27 Apr 2022 21:10:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1E93C385A7; Wed, 27 Apr 2022 21:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651093803; bh=12d6/CBzd02oZvju7Qb4kipcwNr/RTQQkKKMy0Kf12g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=twwMhuUM80iWBGPxpkH6nihQbKdGbY8ApqTOdU9m3p7gW4vXcLj+Nr2ypQMqPy2W2 rV72B33XDzC/nevkPH5MUV8x8P7r+UAoThbsyGEYzJAIV+NKp3cgg+THJjQJLupPg2 k+ZtpnDcIj1YEjmYVH8AN9EHlBiKzP9h8gJ8zzrX8jbwgS538/qMPU2gYs2//i1vNY JO+/Graaii7w6EhWj3VkNFc1KFXlWRcw/S9wDncsD08nBe1Nqr7KAZvuN/rMPxlUF0 TuJvPYhgm4FfB/TvrNa0QXTnrUuJNR/2/qGQDGGE7jJmWlZsLWgrhL6BfsAPTMsYLv imqE6HD+7yNLw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1njovB-007Tda-95; Wed, 27 Apr 2022 22:10:01 +0100 Date: Wed, 27 Apr 2022 22:10:01 +0100 Message-ID: <87y1zq8c7q.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: Oliver Upton , james.morse@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH] KVM/arm64: Don't emulate a PMU for 32-bit guests if feature not set In-Reply-To: References: <20220425145530.723858-1-alexandru.elisei@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, oupton@google.com, james.morse@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_141008_538410_92991460 X-CRM114-Status: GOOD ( 21.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Apr 2022 10:45:39 +0100, Alexandru Elisei wrote: > > Hi, > > On Wed, Apr 27, 2022 at 12:57:57AM -0700, Oliver Upton wrote: > > Hi Alex, > > > > Seems to me all the AArch32 feature register trap logic should come > > later on as there's a nonzero chance I introduced a bug :) Shall we > > stop the bleeding w/ your originally proposed patch? Doesn't seem any > > more objectionable than what we're already doing. > > I am leaning towards merging this patch to prevent people from seeing the > splat, and when the AArch32 ID reg series gets merged it can be reverted. > But in the end it's up to Marc to decide what he prefers. Yeah, I'd like to plug this ASAP. I'll queue the workaround for 5.18, and we can rework that the proper way for 5.19. Thanks to both for working on it together, much appreciated. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel