All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Kshitij Suri <kshitij.suri@nutanix.com>
Cc: soham.ghosh@nutanix.com, peter.maydell@linaro.org,
	thuth@redhat.com, berrange@redhat.com, prerna.saxena@nutanix.com,
	qemu-devel@nongnu.org, dgilbert@redhat.com,
	philippe.mathieu.daude@gmail.com, kraxel@redhat.com,
	pbonzini@redhat.com, prachatos.mitra@nutanix.com,
	eblake@redhat.com
Subject: Re: [PATCH v5 2/2] Added parameter to take screenshot with screendump as PNG
Date: Thu, 21 Apr 2022 15:55:09 +0200	[thread overview]
Message-ID: <87y1zysfr6.fsf@pond.sub.org> (raw)
In-Reply-To: <20220408071336.99839-3-kshitij.suri@nutanix.com> (Kshitij Suri's message of "Fri, 8 Apr 2022 07:13:35 +0000")

Kshitij Suri <kshitij.suri@nutanix.com> writes:

> Currently screendump only supports PPM format, which is un-compressed. Added
> a "format" parameter to QMP and HMP screendump command to support PNG image
> capture using libpng.
>
> QMP example usage:
> { "execute": "screendump", "arguments": { "filename": "/tmp/image",
> "format":"png" } }
>
> HMP example usage:
> screendump /tmp/image -f png
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/718
>
> Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>



  parent reply	other threads:[~2022-04-21 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  7:13 [PATCH v5 0/2] Option to take screenshot with screendump as PNG Kshitij Suri
2022-04-08  7:13 ` [PATCH v5 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG Kshitij Suri
2022-04-08  7:13 ` [PATCH v5 2/2] Added parameter to take screenshot with screendump as PNG Kshitij Suri
2022-04-20  9:46   ` Dr. David Alan Gilbert
2022-04-21 13:55   ` Markus Armbruster [this message]
2022-04-14  8:55 ` [PATCH v5 0/2] Option " Kshitij Suri
2022-04-21 13:57   ` Markus Armbruster
2022-04-22 10:50     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1zysfr6.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kshitij.suri@nutanix.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philippe.mathieu.daude@gmail.com \
    --cc=prachatos.mitra@nutanix.com \
    --cc=prerna.saxena@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=soham.ghosh@nutanix.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.