From: Markus Armbruster <armbru@redhat.com>
To: "Zhang, Chen" <chen.zhang@intel.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector
Date: Fri, 05 Nov 2021 07:10:39 +0100 [thread overview]
Message-ID: <87y2635e00.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <DM5PR11MB002701BF07DCC15BF968A1749B8E9@DM5PR11MB0027.namprd11.prod.outlook.com> (Chen Zhang's message of "Fri, 5 Nov 2021 05:29:24 +0000")
"Zhang, Chen" <chen.zhang@intel.com> writes:
>> -----Original Message-----
>> From: Jason Wang <jasowang@redhat.com>
>> Sent: Friday, November 5, 2021 12:03 PM
>> To: Zhang, Chen <chen.zhang@intel.com>
>> Cc: Markus Armbruster <armbru@redhat.com>; qemu-dev <qemu-
>> devel@nongnu.org>; Li Zhijian <lizhijian@cn.fujitsu.com>
>> Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector
>>
>> On Fri, Nov 5, 2021 at 11:27 AM Zhang, Chen <chen.zhang@intel.com> wrote:
>> >
>> >
>> >
>> > > -----Original Message-----
>> > > From: Jason Wang <jasowang@redhat.com>
>> > > Sent: Friday, November 5, 2021 11:17 AM
>> > > To: Zhang, Chen <chen.zhang@intel.com>; Markus Armbruster
>> > > <armbru@redhat.com>
>> > > Cc: qemu-dev <qemu-devel@nongnu.org>; Li Zhijian
>> > > <lizhijian@cn.fujitsu.com>
>> > > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol
>> > > for filter- mirror/redirector
>> > >
>> > >
>> > > 在 2021/11/4 下午1:37, Zhang, Chen 写道:
>> > > > Hi Jason/Markus,
>> > > >
>> > > > Rethink about it, How about keep the original "vnet_hdr_support"
>> > > > function, And add a new optional parameter "auto_vnet_hdr" for filters/compare?
>> > >
>> > >
>> > > It's a way but rethink of the whole thing. I wonder what if we just
>> > > enable "vnet_hdr_support" by default for filter and colo-compare?
>> >
>> > It's works by default for user use -device virtio-net-pci and e1000...
>> > But it can't resolve this series motivation, how to fix/check user configuration issue:
>> > For example user enable " vnet_hdr_support " filter-mirror and disable
>> > " vnet_hdr_support" filter-redirector And connect both filter modules by chardev socket.
>> > In this case guest will get wrong network workload and filters didn’t
>> > perceive any abnormalities, but in fact, the whole system is no longer working.
>> > This series will report error and try to correct it.
>>
>> The problem is how "auto_vnet_hdr" help in this case. It's a new parameter
>> which may lead to more wrong configuration?
>
> No, the "auto_vnet_hdr" will fix most the wrong configuration issues as "vnet_hdr_support" correct setting.
> When we enable the "auto_vnet_hdr", the original "vnet_hdr_support" will no effect.
I don't know enough to help much here. What I do know: having to
specify an obscure parameter to get a nicer user interface is
backwards. Is this the case here?
next prev parent reply other threads:[~2021-11-05 6:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 9:05 [PATCH V5 0/3] net/filter: Optimize filters vnet_hdr support Zhang Chen
2021-10-28 9:05 ` [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector Zhang Chen
2021-10-29 3:11 ` Jason Wang
2021-10-29 8:08 ` Zhang, Chen
2021-11-01 3:46 ` Jason Wang
2021-11-01 7:15 ` Zhang, Chen
2021-11-04 5:37 ` Zhang, Chen
2021-11-05 3:16 ` Jason Wang
2021-11-05 3:27 ` Zhang, Chen
2021-11-05 4:03 ` Jason Wang
2021-11-05 5:29 ` Zhang, Chen
2021-11-05 6:10 ` Markus Armbruster [this message]
2021-11-05 8:30 ` Jason Wang
2021-11-05 8:43 ` Zhang, Chen
2021-11-08 2:41 ` Jason Wang
2021-11-08 2:50 ` Zhang, Chen
2021-11-09 6:42 ` Jason Wang
2021-11-09 7:20 ` Zhang, Chen
2021-11-09 7:26 ` Jason Wang
2021-11-09 7:31 ` Zhang, Chen
2021-11-09 7:42 ` Jason Wang
2021-11-09 7:47 ` Zhang, Chen
2021-11-10 2:31 ` Zhang, Chen
2021-10-28 9:05 ` [PATCH V5 2/3] net/filter: Optimize transfer protocol for filter-rewriter Zhang Chen
2021-10-28 9:05 ` [PATCH V5 3/3] net/colo-compare.c: Optimize transfer protocol for colo-compare Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2635e00.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.