From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB5EC433F5 for ; Mon, 11 Oct 2021 08:15:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 06F3D60EFE for ; Mon, 11 Oct 2021 08:15:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 06F3D60EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 881A84B0D0; Mon, 11 Oct 2021 04:15:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3kA1my16ZKd2; Mon, 11 Oct 2021 04:15:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4D6C14B091; Mon, 11 Oct 2021 04:15:19 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 69F9E4AC78 for ; Mon, 11 Oct 2021 04:15:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ar5or6CQMRoM for ; Mon, 11 Oct 2021 04:15:17 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6AA084079A for ; Mon, 11 Oct 2021 04:15:17 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F02A60ED4; Mon, 11 Oct 2021 08:15:16 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mZqSo-00FxTa-3C; Mon, 11 Oct 2021 09:15:14 +0100 Date: Mon, 11 Oct 2021 09:15:13 +0100 Message-ID: <87y270ou3y.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Subject: Re: [PATCH v8 03/15] KVM: arm64: selftests: Use read/write definitions from sysreg.h In-Reply-To: <20211007233439.1826892-4-rananta@google.com> References: <20211007233439.1826892-1-rananta@google.com> <20211007233439.1826892-4-rananta@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, pbonzini@redhat.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Will Deacon , Catalin Marinas , Peter Shier , linux-kernel@vger.kernel.org, Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Raghavendra, On Fri, 08 Oct 2021 00:34:27 +0100, Raghavendra Rao Ananta wrote: > > Make use of the register read/write definitions from > sysreg.h, instead of the existing definitions. A syntax > correction is needed for the files that use write_sysreg() > to make it compliant with the new (kernel's) syntax. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Oliver Upton > Reviewed-by: Andrew Jones > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 28 +++++++++---------- > .../selftests/kvm/include/aarch64/processor.h | 13 +-------- > 2 files changed, 15 insertions(+), 26 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index e5e6c92b60da..11fd23e21cb4 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -34,16 +34,16 @@ static void reset_debug_state(void) > { > asm volatile("msr daifset, #8"); > > - write_sysreg(osdlr_el1, 0); > - write_sysreg(oslar_el1, 0); > + write_sysreg(0, osdlr_el1); > + write_sysreg(0, oslar_el1); The previous patch has obviously introduced significant breakage which this patch is now fixing. In the interval, the build is broken, which isn't great. You can either rework this series to work around the issue, or I can squash patches #2 and #3 together. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178C3C433EF for ; Mon, 11 Oct 2021 08:18:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3AC0600CD for ; Mon, 11 Oct 2021 08:18:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3AC0600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QHFMjIQ1lRhavXfRwjZ6nfIPnqwX1Gyz6kPrwA18xH0=; b=dvRtE8XmcZ94Tn +6Jkiyrdo4x0yKwV3cbEGd3gp8vggUcq/XGxOfIw0SgQpp50cfqI0P24V5SJA5xAApPmrxUoB1yts 4iv8MfzUobTlmcNrREPiQ8Boyi39pgFe4B7o3Zfo6xDsQeN8u6EbLwC0K9AusUHko2qbT7TQ0lTzr zx+ckxgGyywmWhYDSqYBIO7KCaLuWagiulyQQQ2twIr+QffWFdCezOWimmIdYefZu5/ej6RpTbgcD 5NotYtnf1IIzAokMLghE1vORWU5l6+JtsFGDsa4c/P0Pu1fNpTiWhg3ZoLHQencVUsVsR5Zej7VIS KRCr39jL3BVUe6R4mpsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZqSu-008GCv-D9; Mon, 11 Oct 2021 08:15:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZqSq-008GCO-Oz for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 08:15:18 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F02A60ED4; Mon, 11 Oct 2021 08:15:16 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mZqSo-00FxTa-3C; Mon, 11 Oct 2021 09:15:14 +0100 Date: Mon, 11 Oct 2021 09:15:13 +0100 Message-ID: <87y270ou3y.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 03/15] KVM: arm64: selftests: Use read/write definitions from sysreg.h In-Reply-To: <20211007233439.1826892-4-rananta@google.com> References: <20211007233439.1826892-1-rananta@google.com> <20211007233439.1826892-4-rananta@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, pbonzini@redhat.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_011516_854521_428F05FF X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Raghavendra, On Fri, 08 Oct 2021 00:34:27 +0100, Raghavendra Rao Ananta wrote: > > Make use of the register read/write definitions from > sysreg.h, instead of the existing definitions. A syntax > correction is needed for the files that use write_sysreg() > to make it compliant with the new (kernel's) syntax. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Oliver Upton > Reviewed-by: Andrew Jones > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 28 +++++++++---------- > .../selftests/kvm/include/aarch64/processor.h | 13 +-------- > 2 files changed, 15 insertions(+), 26 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index e5e6c92b60da..11fd23e21cb4 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -34,16 +34,16 @@ static void reset_debug_state(void) > { > asm volatile("msr daifset, #8"); > > - write_sysreg(osdlr_el1, 0); > - write_sysreg(oslar_el1, 0); > + write_sysreg(0, osdlr_el1); > + write_sysreg(0, oslar_el1); The previous patch has obviously introduced significant breakage which this patch is now fixing. In the interval, the build is broken, which isn't great. You can either rework this series to work around the issue, or I can squash patches #2 and #3 together. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A87C433EF for ; Mon, 11 Oct 2021 08:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47F3D60F0F for ; Mon, 11 Oct 2021 08:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234889AbhJKIRQ (ORCPT ); Mon, 11 Oct 2021 04:17:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:47362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbhJKIRP (ORCPT ); Mon, 11 Oct 2021 04:17:15 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F02A60ED4; Mon, 11 Oct 2021 08:15:16 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mZqSo-00FxTa-3C; Mon, 11 Oct 2021 09:15:14 +0100 Date: Mon, 11 Oct 2021 09:15:13 +0100 Message-ID: <87y270ou3y.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 03/15] KVM: arm64: selftests: Use read/write definitions from sysreg.h In-Reply-To: <20211007233439.1826892-4-rananta@google.com> References: <20211007233439.1826892-1-rananta@google.com> <20211007233439.1826892-4-rananta@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, pbonzini@redhat.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Raghavendra, On Fri, 08 Oct 2021 00:34:27 +0100, Raghavendra Rao Ananta wrote: > > Make use of the register read/write definitions from > sysreg.h, instead of the existing definitions. A syntax > correction is needed for the files that use write_sysreg() > to make it compliant with the new (kernel's) syntax. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Oliver Upton > Reviewed-by: Andrew Jones > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 28 +++++++++---------- > .../selftests/kvm/include/aarch64/processor.h | 13 +-------- > 2 files changed, 15 insertions(+), 26 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index e5e6c92b60da..11fd23e21cb4 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -34,16 +34,16 @@ static void reset_debug_state(void) > { > asm volatile("msr daifset, #8"); > > - write_sysreg(osdlr_el1, 0); > - write_sysreg(oslar_el1, 0); > + write_sysreg(0, osdlr_el1); > + write_sysreg(0, oslar_el1); The previous patch has obviously introduced significant breakage which this patch is now fixing. In the interval, the build is broken, which isn't great. You can either rework this series to work around the issue, or I can squash patches #2 and #3 together. Thanks, M. -- Without deviation from the norm, progress is not possible.