From: Valentin Schneider <valentin.schneider@arm.com>
To: Yicong Yang <yangyicong@hisilicon.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, 21cnbao@gmail.com
Cc: linux-kernel@vger.kernel.org, song.bao.hua@hisilicon.com,
prime.zeng@huawei.com, yangyicong@hisilicon.com
Subject: Re: [RESEND PATCH] sched/topology: Remove unused numa_distance in cpu_attach_domain()
Date: Mon, 04 Oct 2021 16:20:39 +0100 [thread overview]
Message-ID: <87y278lsu0.mognet@arm.com> (raw)
In-Reply-To: <20210915063158.80639-1-yangyicong@hisilicon.com>
On 15/09/21 14:31, Yicong Yang wrote:
> numa_distance in cpu_attach_domain() is introduced in
> commit b5b217346de8 ("sched/topology: Warn when NUMA diameter > 2")
> to warn user when NUMA diameter > 2 as we'll misrepresent
> the scheduler topology structures at that time. This is
> fixed by Barry in commit 585b6d2723dc ("sched/topology: fix the issue
> groups don't span domain->span for NUMA diameter > 2") and
> numa_distance is unused now. So remove it.
>
Ah, 585b6d2723dc didn't contain a proper revert of b5b217346de8, leaving
those hunks behind.
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
next prev parent reply other threads:[~2021-10-04 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:31 [RESEND PATCH] sched/topology: Remove unused numa_distance in cpu_attach_domain() Yicong Yang
2021-09-16 9:42 ` Barry Song
2021-10-04 15:20 ` Valentin Schneider [this message]
2021-10-09 10:07 ` [tip: sched/core] " tip-bot2 for Yicong Yang
2021-10-14 11:16 ` tip-bot2 for Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y278lsu0.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=21cnbao@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=song.bao.hua@hisilicon.com \
--cc=vincent.guittot@linaro.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.