Re: [PATCH 3/4] rtw88: support adaptivity for ETSI/JP DFS region

[Kalle Valo <kvalo@codeaurora.org>]

Pkshih <pkshih@realtek.com> writes:

>> > --- a/drivers/net/wireless/realtek/rtw88/main.c
>> > +++ b/drivers/net/wireless/realtek/rtw88/main.c
>> > @@ -23,6 +23,7 @@ EXPORT_SYMBOL(rtw_disable_lps_deep_mode);
>> >  bool rtw_bf_support = true;
>> >  unsigned int rtw_debug_mask;
>> >  EXPORT_SYMBOL(rtw_debug_mask);
>> > +bool rtw_edcca_enabled = true;
>> 
>> You are making rtw_edcca_enabled per driver, should it instead be per
>> device? If something is changed via debugfs the assumption is that the
>> value is per device.
>> 
>> For example, let's say you have two rtw88 devices attached on the same
>> system, device A and B. If a user changes edcca via debugfs on device A
>> it will also change the state in device B. Is that the desired
>> functionality? If yes, I think you should add a comment to
>> rtw_edcca_enabled explaining that.
>> 
>
> As mentioned in commit message, the debugfs is expected to be used when debugging
> in noisy environment. In that case, we think all rtw88 devices will probably
> be affected. Besides, we believe that turning EDCCA off is a temporary state under
> debugging.
>
> Based on the two points, it seems no need to maintain rtw_edcca_enabled by device,
> so a comment will be added to explain this.

Ok, fair enough.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches