From: Felipe Balbi <balbi@kernel.org>
To: Maxim Devaev <mdevaev@gmail.com>
Cc: gregkh@linuxfoundation.org, sandeen@redhat.com,
linux-usb@vger.kernel.org, mdevaev@gmail.com
Subject: Re: [PATCH] usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers
Date: Thu, 22 Jul 2021 14:49:38 +0300 [thread overview]
Message-ID: <87y29ylga5.fsf@kernel.org> (raw)
In-Reply-To: <20210721180351.129450-1-mdevaev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Maxim Devaev <mdevaev@gmail.com> writes:
> The USB HID standard declares mandatory support for GET_IDLE and SET_IDLE
> requests for Boot Keyboard. Most hosts can handle their absence, but others
> like some old/strange UEFIs and BIOSes consider this a critical error
> and refuse to work with f_hid.
>
> This primitive implementation of saving and returning idle is sufficient
> to meet the requirements of the standard and these devices.
>
> Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
yeah, I don't see any issues with this. If you have access to the tool,
mind running USBCV on the f_hid gadget? Would be cool to get some
confirmation that we're within spec.
That shouldn't gate $subject though.
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-07-22 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 18:03 [PATCH] usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers Maxim Devaev
2021-07-22 11:49 ` Felipe Balbi [this message]
2021-07-22 17:51 ` Maxim Devaev
2021-07-23 7:20 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y29ylga5.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdevaev@gmail.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.