From: Cornelia Huck <cohuck@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, thuth@redhat.com, lvivier@redhat.com,
david@redhat.com
Subject: Re: [PATCH kvm-unit-tests] generators: unify header guards
Date: Mon, 14 Jun 2021 11:57:06 +0200 [thread overview]
Message-ID: <87y2bcydjh.fsf@redhat.com> (raw)
In-Reply-To: <20210614090723.30208-1-drjones@redhat.com>
On Mon, Jun 14 2021, Andrew Jones <drjones@redhat.com> wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> configure | 4 ++--
> scripts/asm-offsets.mak | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index 4ad5a4bcd782..b8442d61fb60 100755
> --- a/configure
> +++ b/configure
> @@ -332,8 +332,8 @@ if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
> fi
>
> cat <<EOF > lib/config.h
> -#ifndef CONFIG_H
> -#define CONFIG_H 1
> +#ifndef _CONFIG_H_
> +#define _CONFIG_H_
> /*
> * Generated file. DO NOT MODIFY.
> *
Already changed in "header guards: clean up some stragglers", seems that
patch has not been applied yet.
> diff --git a/scripts/asm-offsets.mak b/scripts/asm-offsets.mak
> index 7b64162dd2e1..2b9be2b439f4 100644
> --- a/scripts/asm-offsets.mak
> +++ b/scripts/asm-offsets.mak
> @@ -17,8 +17,8 @@ endef
>
> define make_asm_offsets
> (set -e; \
> - echo "#ifndef __ASM_OFFSETS_H__"; \
> - echo "#define __ASM_OFFSETS_H__"; \
> + echo "#ifndef _ASM_OFFSETS_H_"; \
> + echo "#define _ASM_OFFSETS_H_"; \
> echo "/*"; \
> echo " * Generated file. DO NOT MODIFY."; \
> echo " *"; \
For the second hunk:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2021-06-14 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 9:07 [PATCH kvm-unit-tests] generators: unify header guards Andrew Jones
2021-06-14 9:57 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2bcydjh.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.