Re: [PATCH] irq_pipeline: Prevent returning to user space with pending inband IRQs

[Philippe Gerum <rpm@xenomai.org>]

Philippe Gerum <rpm@xenomai.org> writes:

> Philippe Gerum <rpm@xenomai.org> writes:
>>
>> 2. This one should be replaced by a fix in local_irq_disable_full(),
>> pending some tests ongoing here:
>>
>> irq_pipeline: Prevent returning to user space with pending inband IRQs
>>
>
> Tests went ok. So [1] should be replaced by a patch inverting the order
> in local_irq_disable_full() as we discussed.
>
> [1] irq_pipeline: Prevent returning to user space with pending inband IRQs

Likewise for local_irq_save_full() which may cause the same problem,
i.e.:

diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
index 8663f19cc7b7b68..051c72751db42d1 100644
--- a/include/linux/irqflags.h
+++ b/include/linux/irqflags.h
@@ -242,14 +242,14 @@ do {						\
 
 #define local_irq_disable_full()		\
 	do {					\
-		local_irq_disable();		\
 		hard_local_irq_disable();	\
+		local_irq_disable();		\
 	} while (0)
 
 #define local_irq_save_full(__flags)		\
   	do {					\
-		local_irq_save(__flags);	\
 		hard_local_irq_disable();	\
+		local_irq_save(__flags);	\
 	} while (0)
 
 #define local_irq_restore_full(__flags)			\
 
-- 
Philippe.