From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019BDC433C1 for ; Mon, 29 Mar 2021 15:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C000561968 for ; Mon, 29 Mar 2021 15:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbhC2PSI convert rfc822-to-8bit (ORCPT ); Mon, 29 Mar 2021 11:18:08 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:33475 "EHLO mslow1.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230347AbhC2PSD (ORCPT ); Mon, 29 Mar 2021 11:18:03 -0400 Received: from relay9-d.mail.gandi.net (unknown [217.70.183.199]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 2DB4ED1502; Mon, 29 Mar 2021 14:48:28 +0000 (UTC) X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 47462FF809; Mon, 29 Mar 2021 14:48:05 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Miquel Raynal , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin Subject: Re: [PATCH mvebu v3 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz In-Reply-To: <20210222194158.12342-6-pali@kernel.org> References: <20210114124032.12765-1-pali@kernel.org> <20210222194158.12342-1-pali@kernel.org> <20210222194158.12342-6-pali@kernel.org> Date: Mon, 29 Mar 2021 16:48:04 +0200 Message-ID: <87y2e6dniz.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Pali Rohár writes: > It was observed that the workaround introduced by commit 61c40f35f5cd > ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to > 1.2GHz") when base CPU frequency is 1.2 GHz is also required when base > CPU frequency is 1 GHz. Otherwise switching CPU frequency directly from > L2 (250 MHz) to L0 (1 GHz) causes a crash. > > When base CPU frequency is just 800 MHz no crashed were observed during > switch from L2 to L0. > > Signed-off-by: Pali Rohár > Acked-by: Stephen Boyd > Tested-by: Tomasz Maciej Nowak > Tested-by: Anders Trier Olesen > Tested-by: Philip Soares > Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for cpu clocks") > Cc: stable@vger.kernel.org # 61c40f35f5cd ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to 1.2GHz") Acked-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/clk/mvebu/armada-37xx-periph.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c > index 6507bd2c5f31..b15e177bea7e 100644 > --- a/drivers/clk/mvebu/armada-37xx-periph.c > +++ b/drivers/clk/mvebu/armada-37xx-periph.c > @@ -487,8 +487,10 @@ static long clk_pm_cpu_round_rate(struct clk_hw *hw, unsigned long rate, > } > > /* > - * Switching the CPU from the L2 or L3 frequencies (300 and 200 Mhz > - * respectively) to L0 frequency (1.2 Ghz) requires a significant > + * Workaround when base CPU frequnecy is 1000 or 1200 MHz > + * > + * Switching the CPU from the L2 or L3 frequencies (250/300 or 200 MHz > + * respectively) to L0 frequency (1/1.2 GHz) requires a significant > * amount of time to let VDD stabilize to the appropriate > * voltage. This amount of time is large enough that it cannot be > * covered by the hardware countdown register. Due to this, the CPU > @@ -498,15 +500,15 @@ static long clk_pm_cpu_round_rate(struct clk_hw *hw, unsigned long rate, > * To work around this problem, we prevent switching directly from the > * L2/L3 frequencies to the L0 frequency, and instead switch to the L1 > * frequency in-between. The sequence therefore becomes: > - * 1. First switch from L2/L3(200/300MHz) to L1(600MHZ) > + * 1. First switch from L2/L3 (200/250/300 MHz) to L1 (500/600 MHz) > * 2. Sleep 20ms for stabling VDD voltage > - * 3. Then switch from L1(600MHZ) to L0(1200Mhz). > + * 3. Then switch from L1 (500/600 MHz) to L0 (1000/1200 MHz). > */ > static void clk_pm_cpu_set_rate_wa(unsigned long rate, struct regmap *base) > { > unsigned int cur_level; > > - if (rate != 1200 * 1000 * 1000) > + if (rate < 1000 * 1000 * 1000) > return; > > regmap_read(base, ARMADA_37XX_NB_CPU_LOAD, &cur_level); > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4DEC433DB for ; Mon, 29 Mar 2021 22:57:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D370661919 for ; Mon, 29 Mar 2021 22:57:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D370661919 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TkCqudK6AZsx3MaNynMTKWNEDvotoQ4mMhKE79SyjMg=; b=OSfdALBPJSyokyg4rcxOQRiJh pJdXAmudfPJGp628A9KEuHNjNT+d3chpX/yGmPhG0B/eu1HHULLsNnys75HY+Cm9/zbddoMD2Ov48 RNHZUe97FPZJ0v3TvPmSwW2F+btDsEnZZOJ7N3nzjIh2PC65v5HKGzkbWbyy73917Lz48HnGRduoY WoeMTZHCHOiu2/IAB9UIgougXVLG0at63OVGs6zmpUIlj0jl12NW7nRzzSmjmS7gplrVO2YRO2YDD aKwp8H/Dshdl+qaS8n485RB2vKvHawJz5CnLiwWRRkZQgrHD3LwpJ4s+305xRGVZOuO4NtGrAcj9E ukde6ArQA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR0mw-001mbU-9m; Mon, 29 Mar 2021 22:55:14 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQtBW-000igv-LE for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 14:48:26 +0000 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 47462FF809; Mon, 29 Mar 2021 14:48:05 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Miquel Raynal , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin Subject: Re: [PATCH mvebu v3 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz In-Reply-To: <20210222194158.12342-6-pali@kernel.org> References: <20210114124032.12765-1-pali@kernel.org> <20210222194158.12342-1-pali@kernel.org> <20210222194158.12342-6-pali@kernel.org> Date: Mon, 29 Mar 2021 16:48:04 +0200 Message-ID: <87y2e6dniz.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_154823_753339_0F1536A5 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4gd3JpdGVzOgoKPiBJdCB3YXMgb2JzZXJ2ZWQg dGhhdCB0aGUgd29ya2Fyb3VuZCBpbnRyb2R1Y2VkIGJ5IGNvbW1pdCA2MWM0MGYzNWY1Y2QKPiAo ImNsazogbXZlYnU6IGFybWFkYS0zN3h4LXBlcmlwaDogRml4IHN3aXRjaGluZyBDUFUgcmF0ZSBm cm9tIDMwME1oeiB0bwo+IDEuMkdIeiIpIHdoZW4gYmFzZSBDUFUgZnJlcXVlbmN5IGlzIDEuMiBH SHogaXMgYWxzbyByZXF1aXJlZCB3aGVuIGJhc2UKPiBDUFUgZnJlcXVlbmN5IGlzIDEgR0h6LiBP dGhlcndpc2Ugc3dpdGNoaW5nIENQVSBmcmVxdWVuY3kgZGlyZWN0bHkgZnJvbQo+IEwyICgyNTAg TUh6KSB0byBMMCAoMSBHSHopIGNhdXNlcyBhIGNyYXNoLgo+Cj4gV2hlbiBiYXNlIENQVSBmcmVx dWVuY3kgaXMganVzdCA4MDAgTUh6IG5vIGNyYXNoZWQgd2VyZSBvYnNlcnZlZCBkdXJpbmcKPiBz d2l0Y2ggZnJvbSBMMiB0byBMMC4KPgo+IFNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxp QGtlcm5lbC5vcmc+Cj4gQWNrZWQtYnk6IFN0ZXBoZW4gQm95ZCA8c2JveWRAa2VybmVsLm9yZz4K PiBUZXN0ZWQtYnk6IFRvbWFzeiBNYWNpZWogTm93YWsgPHRtbjUwNUBnbWFpbC5jb20+Cj4gVGVz dGVkLWJ5OiBBbmRlcnMgVHJpZXIgT2xlc2VuIDxhbmRlcnMudHJpZXIub2xlc2VuQGdtYWlsLmNv bT4KPiBUZXN0ZWQtYnk6IFBoaWxpcCBTb2FyZXMgPHBoaWxpcHNAbmV0aXNlbnNlLmNvbT4KPiBG aXhlczogMjA4OWRjMzNlYTBlICgiY2xrOiBtdmVidTogYXJtYWRhLTM3eHgtcGVyaXBoOiBhZGQg RFZGUyBzdXBwb3J0IGZvciBjcHUgY2xvY2tzIikKPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9y ZyAjIDYxYzQwZjM1ZjVjZCAoImNsazogbXZlYnU6IGFybWFkYS0zN3h4LXBlcmlwaDogRml4IHN3 aXRjaGluZyBDUFUgcmF0ZSBmcm9tIDMwME1oeiB0byAxLjJHSHoiKQoKCkFja2VkLWJ5OiBHcmVn b3J5IENMRU1FTlQgPGdyZWdvcnkuY2xlbWVudEBib290bGluLmNvbT4KClRoYW5rcywKCkdyZWdv cnkKCj4gLS0tCj4gIGRyaXZlcnMvY2xrL212ZWJ1L2FybWFkYS0zN3h4LXBlcmlwaC5jIHwgMTIg KysrKysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDUgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvbXZlYnUvYXJtYWRhLTM3eHgtcGVy aXBoLmMgYi9kcml2ZXJzL2Nsay9tdmVidS9hcm1hZGEtMzd4eC1wZXJpcGguYwo+IGluZGV4IDY1 MDdiZDJjNWYzMS4uYjE1ZTE3N2JlYTdlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvY2xrL212ZWJ1 L2FybWFkYS0zN3h4LXBlcmlwaC5jCj4gKysrIGIvZHJpdmVycy9jbGsvbXZlYnUvYXJtYWRhLTM3 eHgtcGVyaXBoLmMKPiBAQCAtNDg3LDggKzQ4NywxMCBAQCBzdGF0aWMgbG9uZyBjbGtfcG1fY3B1 X3JvdW5kX3JhdGUoc3RydWN0IGNsa19odyAqaHcsIHVuc2lnbmVkIGxvbmcgcmF0ZSwKPiAgfQo+ ICAKPiAgLyoKPiAtICogU3dpdGNoaW5nIHRoZSBDUFUgZnJvbSB0aGUgTDIgb3IgTDMgZnJlcXVl bmNpZXMgKDMwMCBhbmQgMjAwIE1oego+IC0gKiByZXNwZWN0aXZlbHkpIHRvIEwwIGZyZXF1ZW5j eSAoMS4yIEdoeikgcmVxdWlyZXMgYSBzaWduaWZpY2FudAo+ICsgKiBXb3JrYXJvdW5kIHdoZW4g YmFzZSBDUFUgZnJlcXVuZWN5IGlzIDEwMDAgb3IgMTIwMCBNSHoKPiArICoKPiArICogU3dpdGNo aW5nIHRoZSBDUFUgZnJvbSB0aGUgTDIgb3IgTDMgZnJlcXVlbmNpZXMgKDI1MC8zMDAgb3IgMjAw IE1Iego+ICsgKiByZXNwZWN0aXZlbHkpIHRvIEwwIGZyZXF1ZW5jeSAoMS8xLjIgR0h6KSByZXF1 aXJlcyBhIHNpZ25pZmljYW50Cj4gICAqIGFtb3VudCBvZiB0aW1lIHRvIGxldCBWREQgc3RhYmls aXplIHRvIHRoZSBhcHByb3ByaWF0ZQo+ICAgKiB2b2x0YWdlLiBUaGlzIGFtb3VudCBvZiB0aW1l IGlzIGxhcmdlIGVub3VnaCB0aGF0IGl0IGNhbm5vdCBiZQo+ICAgKiBjb3ZlcmVkIGJ5IHRoZSBo YXJkd2FyZSBjb3VudGRvd24gcmVnaXN0ZXIuIER1ZSB0byB0aGlzLCB0aGUgQ1BVCj4gQEAgLTQ5 OCwxNSArNTAwLDE1IEBAIHN0YXRpYyBsb25nIGNsa19wbV9jcHVfcm91bmRfcmF0ZShzdHJ1Y3Qg Y2xrX2h3ICpodywgdW5zaWduZWQgbG9uZyByYXRlLAo+ICAgKiBUbyB3b3JrIGFyb3VuZCB0aGlz IHByb2JsZW0sIHdlIHByZXZlbnQgc3dpdGNoaW5nIGRpcmVjdGx5IGZyb20gdGhlCj4gICAqIEwy L0wzIGZyZXF1ZW5jaWVzIHRvIHRoZSBMMCBmcmVxdWVuY3ksIGFuZCBpbnN0ZWFkIHN3aXRjaCB0 byB0aGUgTDEKPiAgICogZnJlcXVlbmN5IGluLWJldHdlZW4uIFRoZSBzZXF1ZW5jZSB0aGVyZWZv cmUgYmVjb21lczoKPiAtICogMS4gRmlyc3Qgc3dpdGNoIGZyb20gTDIvTDMoMjAwLzMwME1Ieikg dG8gTDEoNjAwTUhaKQo+ICsgKiAxLiBGaXJzdCBzd2l0Y2ggZnJvbSBMMi9MMyAoMjAwLzI1MC8z MDAgTUh6KSB0byBMMSAoNTAwLzYwMCBNSHopCj4gICAqIDIuIFNsZWVwIDIwbXMgZm9yIHN0YWJs aW5nIFZERCB2b2x0YWdlCj4gLSAqIDMuIFRoZW4gc3dpdGNoIGZyb20gTDEoNjAwTUhaKSB0byBM MCgxMjAwTWh6KS4KPiArICogMy4gVGhlbiBzd2l0Y2ggZnJvbSBMMSAoNTAwLzYwMCBNSHopIHRv IEwwICgxMDAwLzEyMDAgTUh6KS4KPiAgICovCj4gIHN0YXRpYyB2b2lkIGNsa19wbV9jcHVfc2V0 X3JhdGVfd2EodW5zaWduZWQgbG9uZyByYXRlLCBzdHJ1Y3QgcmVnbWFwICpiYXNlKQo+ICB7Cj4g IAl1bnNpZ25lZCBpbnQgY3VyX2xldmVsOwo+ICAKPiAtCWlmIChyYXRlICE9IDEyMDAgKiAxMDAw ICogMTAwMCkKPiArCWlmIChyYXRlIDwgMTAwMCAqIDEwMDAgKiAxMDAwKQo+ICAJCXJldHVybjsK PiAgCj4gIAlyZWdtYXBfcmVhZChiYXNlLCBBUk1BREFfMzdYWF9OQl9DUFVfTE9BRCwgJmN1cl9s ZXZlbCk7Cj4gLS0gCj4gMi4yMC4xCj4KCi0tIApHcmVnb3J5IENsZW1lbnQsIEJvb3RsaW4KRW1i ZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwOi8vYm9vdGxpbi5jb20KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK