From: Paulo Alcantara <pc@cjr.nz>
To: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Cc: Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] cifs: revalidate mapping when we open files for SMB1 POSIX
Date: Thu, 25 Mar 2021 12:34:08 -0300 [thread overview]
Message-ID: <87y2ebdz7z.fsf@cjr.nz> (raw)
In-Reply-To: <20210325062635.43370-1-lsahlber@redhat.com>
Ronnie Sahlberg <lsahlber@redhat.com> writes:
> RHBZ: 1933527
>
> Under SMB1 + POSIX, if an inode is reused on a server after we have read and
> cached a part of a file, when we then open the new file with the
> re-cycled inode there is a chance that we may serve the old data out of cache
> to the application.
> This only happens for SMB1 (deprecated) and when posix are used.
> The simplest solution to avoid this race is to force a revalidate
> on smb1-posix open.
>
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
> fs/cifs/file.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2021-03-25 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 6:26 [PATCH] cifs: revalidate mapping when we open files for SMB1 POSIX Ronnie Sahlberg
2021-03-25 15:34 ` Paulo Alcantara [this message]
2021-03-25 15:42 ` Steve French
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 6:14 Ronnie Sahlberg
2021-03-25 5:23 Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ebdz7z.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.