From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62F2C4332D for ; Wed, 17 Mar 2021 11:08:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DB3664F6A for ; Wed, 17 Mar 2021 11:08:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbhCQLIF (ORCPT ); Wed, 17 Mar 2021 07:08:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47384 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbhCQLHo (ORCPT ); Wed, 17 Mar 2021 07:07:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615979263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sFmaH41LDlPjG9Ynwp45uLWY+uwr7N1DcuUG5izOuw8=; b=OLgkObXWJ7fGt+ohsMwHrhWMqQFtagOkSVoDENf8RAVzuSr7W/8iO3zEjISyAsH3i/tyc8 fTUUiu4wWr+fWatg57+1V9Gm1/mmL0MwaTHH6X9uHr3vickMxUn0htqZPP5mDpeMZZKYR3 qTOecSjjHqgVinlYbZGWZU8sE5vEW2g= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-vhInZDFSM6eeSHbCqgLLKA-1; Wed, 17 Mar 2021 07:07:42 -0400 X-MC-Unique: vhInZDFSM6eeSHbCqgLLKA-1 Received: by mail-ej1-f70.google.com with SMTP id fy8so14991589ejb.19 for ; Wed, 17 Mar 2021 04:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=sFmaH41LDlPjG9Ynwp45uLWY+uwr7N1DcuUG5izOuw8=; b=p3N/HtxZpyoTvnpZ6c6GlfMSUvK2QDjxaHF+nrWaEfQKwCXG4WJV6X7ntCEm+FTYAZ 4XHtQjUTcEFSXfld4rV7XwHzxF9QL4H3vMqhaXdTPBbs9071RbOp1BPZB0dPfxxRx82g MKhVChZf0nqCzhvempXMULU8mwJ11fpYBSNBsKT0G7xV/7T/7I6axvDbq+gPmRedqs8K RjGRGRiiNwQSXj49+vC7K22BGK4gvDMCVF+Z5tplElsX6Rb6f+KNXfkwmNAzz+lkZIap 2B360oc1tEbegyuoPRUHzyKZVukWNV825duuLR/7F3swrPkQp4P2m6OhGftd2o9pfyLX 8RvQ== X-Gm-Message-State: AOAM531z1DAOvNQ+mAutq5RPHC596qKP9FGGV34Hk5hc5/jp62Wuj6KA 4W5QlcjCEjvkyylRmheQGSgO9U0eW44NW2qxcOBhXHtZT/vyIjnKvrsz3zsC+zUsBY7YaFj1U1F tCQi6/wDKyHk+ X-Received: by 2002:a17:906:2314:: with SMTP id l20mr35375414eja.178.1615979260620; Wed, 17 Mar 2021 04:07:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylmtlvBiYwpe22USdjn0rPdjb/Edoq2N3MMGbDCmY44u09j1aukE8925/xi14GcDNAZySNvg== X-Received: by 2002:a17:906:2314:: with SMTP id l20mr35375374eja.178.1615979260206; Wed, 17 Mar 2021 04:07:40 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a22sm11341585ejr.89.2021.03.17.04.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 04:07:39 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 36DC8181F55; Wed, 17 Mar 2021 12:07:39 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kumar Kartikeya Dwivedi Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] libbpf: use SOCK_CLOEXEC when opening the netlink socket In-Reply-To: <20210317104512.4705-1-memxor@gmail.com> References: <20210317104512.4705-1-memxor@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 17 Mar 2021 12:07:39 +0100 Message-ID: <87y2emca2s.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Kumar Kartikeya Dwivedi writes: > Otherwise, there exists a small window between the opening and closing > of the socket fd where it may leak into processes launched by some other > thread. > > Signed-off-by: Kumar Kartikeya Dwivedi FYI, you should be tagging patches with the tree they are targeting. In this case probably the 'bpf' tree (so [PATCH bpf] in the subject). Also, a Fixes: tag would be nice here? -Toke