From: Kalle Valo <kvalo@codeaurora.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, hurricos@gmail.com
Subject: Re: [PATCH] ath9k: fix transmitting to stations in dynamic SMPS mode
Date: Mon, 15 Feb 2021 11:12:06 +0200 [thread overview]
Message-ID: <87y2fpr8yh.fsf@codeaurora.org> (raw)
In-Reply-To: <d668f30a-f911-921f-d329-f6ac872d0bcc@nbd.name> (Felix Fietkau's message of "Mon, 15 Feb 2021 08:20:04 +0100")
Felix Fietkau <nbd@nbd.name> writes:
> On 2021-02-15 05:54, Kalle Valo wrote:
>> Felix Fietkau <nbd@nbd.name> writes:
>>
>>> When transmitting to a receiver in dynamic SMPS mode, all transmissions that
>>> use multiple spatial streams need to be sent using CTS-to-self or RTS/CTS to
>>> give the receiver's extra chains some time to wake up.
>>> This fixes the tx rate getting stuck at <= MCS7 for some clients, especially
>>> Intel ones, which make aggressive use of SMPS.
>>>
>>> Cc: stable@vger.kernel.org
>>> Reported-by: Martin Kennedy <hurricos@gmail.com>
>>> Signed-off-by: Felix Fietkau <nbd@nbd.name>
>>
>> No Fixes tag so I assume this is not a regression?
>>
>> Should this go to v5.12 or -next? I guess that depends how much testing
>> this patch has got.
>
> I'd prefer v5.12. I got confirmation that the patch makes a big
> difference in throughput with Intel clients (makes tx with MCS > 7
> work), and I think there is very little potential for regressions.
Good, I'll queue this to v5.12 then. And we have plenty of time to fix
any regressions anyway.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-02-15 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 18:49 [PATCH] ath9k: fix transmitting to stations in dynamic SMPS mode Felix Fietkau
2021-02-15 4:54 ` Kalle Valo
2021-02-15 7:20 ` Felix Fietkau
2021-02-15 9:12 ` Kalle Valo [this message]
2021-02-18 6:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2fpr8yh.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=hurricos@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.