From: Paolo Valerio <pvalerio@redhat.com>
To: Haiyue Wang <haiyue.wang@intel.com>, dev@dpdk.org
Cc: aconole@redhat.com, david.marchand@redhat.com,
qi.z.zhang@intel.com, leyi.rong@intel.com, Lijuan.Tu@intel.com,
Ruifeng.Wang@arm.com, Feifei.Wang2@arm.com,
Haiyue Wang <haiyue.wang@intel.com>,
stable@dpdk.org, Jeff Guo <jia.guo@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error
Date: Sun, 07 Feb 2021 19:40:45 +0100 [thread overview]
Message-ID: <87y2fz202a.fsf@fed.void> (raw)
In-Reply-To: <20210204143949.22827-1-haiyue.wang@intel.com>
Haiyue Wang <haiyue.wang@intel.com> writes:
> There is an 82599 errata that UDP frames with a zero checksum are
> incorrectly marked as checksum invalid by the hardware. This was
> leading to misleading PKT_RX_L4_CKSUM_BAD flag.
>
> This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN,
> so the software application will then have to recompute the checksum
> itself if needed.
>
> Bugzilla ID: 629
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Reported-by: Paolo Valerio <pvalerio@redhat.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v3: Update the hardware errata doc name and session
> v2: Change the always GOOD checksum to UNKOWN if BAD.
> ---
> doc/guides/nics/ixgbe.rst | 10 ++++++++
> drivers/net/ixgbe/ixgbe_rxtx.c | 30 ++++++++++++++++++++----
> drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++
> drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 32 +++++++++++++++++++++++---
> 4 files changed, 67 insertions(+), 7 deletions(-)
>
Missed the tag in my previous email
Tested-by: Paolo Valerio <pvalerio@redhat.com>
next prev parent reply other threads:[~2021-02-07 18:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 7:06 [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum Haiyue Wang
2021-02-02 9:45 ` David Marchand
2021-02-02 12:42 ` Wang, Haiyue
2021-02-02 12:53 ` David Marchand
2021-02-02 12:56 ` Wang, Haiyue
2021-02-02 14:28 ` Wang, Haiyue
2021-02-02 17:42 ` Paolo Valerio
2021-02-02 12:54 ` Wang, Haiyue
2021-02-03 2:19 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix UDP zero checksum error Haiyue Wang
2021-02-03 8:07 ` Zhang, Qi Z
2021-02-03 8:32 ` David Marchand
2021-02-04 7:45 ` Zhang, Qi Z
2021-02-04 14:39 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
2021-02-05 17:50 ` Paolo Valerio
2021-02-07 18:40 ` Paolo Valerio [this message]
2021-02-08 13:48 ` Ananyev, Konstantin
2021-02-09 1:23 ` Zhang, Qi Z
2021-02-25 10:54 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-04-07 11:53 ` David Marchand
2021-04-08 1:12 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2fz202a.fsf@fed.void \
--to=pvalerio@redhat.com \
--cc=Feifei.Wang2@arm.com \
--cc=Lijuan.Tu@intel.com \
--cc=Ruifeng.Wang@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.