From: Petr Lautrbach <plautrba@redhat.com>
To: SElinux list <selinux@vger.kernel.org>
Cc: Nicolas Iooss <nicolas.iooss@m4x.org>
Subject: Re: [PATCH] policycoreutils/setfiles: Drop unused nerr variable
Date: Wed, 03 Feb 2021 09:34:15 +0100 [thread overview]
Message-ID: <87y2g5mtx4.fsf@redhat.com> (raw)
In-Reply-To: <CAJfZ7==LVUDB7pF2vjr-tRks3svUt-kyy8-N-rVHYjur3HSZNQ@mail.gmail.com>
Nicolas Iooss <nicolas.iooss@m4x.org> writes:
> On Mon, Feb 1, 2021 at 3:32 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>>
>> Suggested-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Merged.
> Thanks!
> Nicolas
>> ---
>> policycoreutils/setfiles/setfiles.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/policycoreutils/setfiles/setfiles.c b/policycoreutils/setfiles/setfiles.c
>> index 92616571ef2a..f018d161aa9e 100644
>> --- a/policycoreutils/setfiles/setfiles.c
>> +++ b/policycoreutils/setfiles/setfiles.c
>> @@ -19,7 +19,6 @@ static int warn_no_match;
>> static int null_terminated;
>> static int request_digest;
>> static struct restore_opts r_opts;
>> -static int nerr;
>>
>> #define STAT_BLOCK_SIZE 1
>>
>> @@ -161,7 +160,6 @@ int main(int argc, char **argv)
>> warn_no_match = 0;
>> request_digest = 0;
>> policyfile = NULL;
>> - nerr = 0;
>>
>> r_opts.abort_on_error = 0;
>> r_opts.progname = strdup(argv[0]);
>> @@ -427,9 +425,6 @@ int main(int argc, char **argv)
>> r_opts.selabel_opt_digest = (request_digest ? (char *)1 : NULL);
>> r_opts.selabel_opt_path = altpath;
>>
>> - if (nerr)
>> - exit(-1);
>> -
>> restore_init(&r_opts);
>>
>> if (use_input_file) {
>> --
>> 2.30.0
>>
prev parent reply other threads:[~2021-02-03 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 14:32 [PATCH] policycoreutils/setfiles: Drop unused nerr variable Petr Lautrbach
2021-02-01 21:55 ` Nicolas Iooss
2021-02-03 8:34 ` Petr Lautrbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2g5mtx4.fsf@redhat.com \
--to=plautrba@redhat.com \
--cc=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.