All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()
Date: Tue, 02 Feb 2021 19:52:23 +0200	[thread overview]
Message-ID: <87y2g6cq7c.fsf@tarshish> (raw)
In-Reply-To: <20210202173724.28394-1-marek.behun@nic.cz>

Hi Marek,

On Tue, Feb 02 2021, Marek Beh?n wrote:
> This is needed to parse more capabilities such as `non-removable`.
>
> Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused
> a regression on Turris Omnia, because mv_sdhci driver did not fill out
> host_caps from device-tree.

I posted a similar patch earlier today:

  https://patchwork.ozlabs.org/project/uboot/patch/7dcd24e8d0149618cf686c47cce6728a64dffe2b.1612248184.git.baruch at tkos.co.il/

> Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
> Fixes: da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect")

My patch is missing this tag, though.

baruch

> Cc: pali at kernel.org
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Stefan Roese <sr@denx.de>
> ---
>  drivers/mmc/mv_sdhci.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index 556dd38046..4dc4a0d2be 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -118,6 +118,10 @@ static int mv_sdhci_probe(struct udevice *dev)
>  	host->mmc->dev = dev;
>  	host->mmc->priv = host;
>  
> +	ret = mmc_of_parse(dev, &plat->cfg);
> +	if (ret)
> +		return ret;
> +
>  	ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
>  	if (ret)
>  		return ret;


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2021-02-02 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210202173759epcas1p25f47e0c37663fa3db9da5b10c7f589e9@epcas1p2.samsung.com>
2021-02-02 17:37 ` [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse() Marek Behún
2021-02-02 17:52   ` Baruch Siach [this message]
2021-02-02 18:02     ` Marek Behún
2021-02-02 23:32   ` Jaehoon Chung
2021-02-03 13:41     ` Marek Behun
2021-02-03 22:18       ` Jaehoon Chung
2021-02-04 16:38         ` Marek Behún
2021-02-04 22:21           ` Jaehoon Chung
2021-02-08 11:40           ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2g6cq7c.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.