From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04DCC10DCE for ; Thu, 12 Mar 2020 14:25:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FB8F20650 for ; Thu, 12 Mar 2020 14:25:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BqzOhKXS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FB8F20650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jCOlV-0006j5-G0; Thu, 12 Mar 2020 14:24:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jCOlT-0006iz-OU for xen-devel@lists.xenproject.org; Thu, 12 Mar 2020 14:24:47 +0000 X-Inumbo-ID: 39d79190-646d-11ea-bec1-bc764e2007e4 Received: from us-smtp-1.mimecast.com (unknown [205.139.110.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 39d79190-646d-11ea-bec1-bc764e2007e4; Thu, 12 Mar 2020 14:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584023087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbZoVTcHQAQqonGG8sHUAE9VwF/9TwX3MkH6fa2Qjxg=; b=BqzOhKXSQAMqDXVC3diGmgou/cTtHFEmaL8T38jacZunTlHWTCahLu+Nh+K2H+AFGZHfTK q7Re8O3NSuJSx9XYWgV6j69WJZnYxo6sJxeD1WuRA1chgBdJLZAVj9e7WHWEKHmM7ET++T y2fF6EDms32Y8SALcXHmkSiRgNhYXrA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-hq-5C0cRNVyDq_aQfYvHuA-1; Thu, 12 Mar 2020 10:24:39 -0400 X-MC-Unique: hq-5C0cRNVyDq_aQfYvHuA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CC3E19251A3; Thu, 12 Mar 2020 14:24:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6EE290795; Thu, 12 Mar 2020 14:24:31 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 33EDB11386A6; Thu, 12 Mar 2020 15:24:30 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy References: <20200312085936.9552-1-vsementsov@virtuozzo.com> Date: Thu, 12 Mar 2020 15:24:30 +0100 In-Reply-To: <20200312085936.9552-1-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Thu, 12 Mar 2020 11:59:26 +0300") Message-ID: <87y2s5ps69.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Xen-devel] [PATCH v9 00/10] error: auto propagated local_err part I X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Michael Roth , qemu-block@nongnu.org, Paul Durrant , Laszlo Ersek , Christian Schoenebeck , qemu-devel@nongnu.org, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPiB3 cml0ZXM6Cgo+IHY5Cj4gMDE6IEEgbG90IG9mIHJld29yZGluZ3MgW3RoYW5rcyB0byBFcmljXQo+ ICAgICBTdGlsbCwga2VlcCBhbGwgci1iIG1hcmtzLCBhc3N1bWluZyB0aGF0IHRoZXkgYXJlIG1v c3RseSBhYm91dCBtYWNybyBkZWZpbml0aW9uCj4gMDI6IHNpZ25pZmljYW50IGNoYW5nZXMgYXJl Ogo+ICAgICAxLiBEbyBub3QgbWF0Y2ggZG91YmxlIHByb3BhZ2F0aW9uIHBhdHRlcm4gaW4gRVJS UF9BVVRPX1BST1BBR0FURS1hZGRpbmcgcnVsZQo+ICAgICAyLiBJbnRyb2R1Y2UgZXJycC0+X19f Xy0+ZXJycCBzY2hlbWUgdG8gbWF0Y2ggb25seSBmdW5jdGlvbnMgbWF0Y2hlZCBieSBydWxlMQo+ ICAgICAgICBpbiBydWxlcyBpbmhlcml0ZWQgZnJvbSBydWxlMQo+ICAgICAzLiBBZGQgcnVsZXMg dG8gd2FybiBhYm91dCB1bnVzdWFsIHBhdHRlcm5zCj4KPiAgICAgQWxzbywgYWRkIGxpbmUgdG8g TUFJTlRBSU5FUlMgdG8ga2VlcCBlcnJvciByZWxhdGVkIGNvY2NpbmVsbGUgc2NyaXB0cyB1bmRl cgo+ICAgICBFcnJvciBzZWN0aW9uLgo+IDA3OiBhZGQgQ2hyaXN0aWFuJ3Mgci1iCj4gMDk6IGFk ZCBFcmljJ3Mgci1iCj4gMTA6IGEgYml0IG9mIGNvbnRleHQgaW4geGVuX2Jsb2NrX2lvdGhyZWFk X2NyZWF0ZSAgYW5kIHFtcF9vYmplY3RfYWRkKCkKPiAgICAgc2lnbmF0dXJlIGFyZSBjaGFuZ2Vk LiBQYXRjaCBjaGFuZ2UgaXMgb2J2aW91cywgc28gSSBrZWVwIFBhdWwncyByLWIKPgo+IHY5IGlz IGF2YWlsYWJsZSBhdAo+ICBodHRwczovL3NyYy5vcGVudnoub3JnL3NjbS9+dnNlbWVudHNvdi9x ZW11LmdpdCAjdGFnIHVwLWF1dG8tbG9jYWwtZXJyLXBhcnRJLXY5CgpEaWQgeW91IGZvcmdldCB0 byBwdXNoIHRoZSB0YWc/Cgo+IHY4IGlzIGF2YWlsYWJsZSBhdAo+ICBodHRwczovL3NyYy5vcGVu dnoub3JnL3NjbS9+dnNlbWVudHNvdi9xZW11LmdpdCAjdGFnIHVwLWF1dG8tbG9jYWwtZXJyLXBh cnRJLXY4ClsuLi5dCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5v cmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZl bA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793BCC1975A for ; Thu, 12 Mar 2020 14:25:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 454D220716 for ; Thu, 12 Mar 2020 14:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ITyutuMQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 454D220716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCOmH-000064-EZ for qemu-devel@archiver.kernel.org; Thu, 12 Mar 2020 10:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCOlX-0007Nv-FS for qemu-devel@nongnu.org; Thu, 12 Mar 2020 10:24:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCOlW-0000Hu-5x for qemu-devel@nongnu.org; Thu, 12 Mar 2020 10:24:51 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:50772 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCOlW-0000Go-2b for qemu-devel@nongnu.org; Thu, 12 Mar 2020 10:24:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584023089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbZoVTcHQAQqonGG8sHUAE9VwF/9TwX3MkH6fa2Qjxg=; b=ITyutuMQDVN0ExjVVLvbVBppz1ObmjezmhZjvnyCEOodlE7oZCjB0XV4uDQn3pjVkXl89k d4LVHoF33oOiZdZQ2x4SEuJ3JrLegkfRgl4lWXb332DkT4PgdLMMvf5k97lJriFCAgtiuY 9kn8/Ak90ltf5Q6VQZJRDCMNb62NZaE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-hq-5C0cRNVyDq_aQfYvHuA-1; Thu, 12 Mar 2020 10:24:39 -0400 X-MC-Unique: hq-5C0cRNVyDq_aQfYvHuA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CC3E19251A3; Thu, 12 Mar 2020 14:24:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6EE290795; Thu, 12 Mar 2020 14:24:31 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 33EDB11386A6; Thu, 12 Mar 2020 15:24:30 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v9 00/10] error: auto propagated local_err part I References: <20200312085936.9552-1-vsementsov@virtuozzo.com> Date: Thu, 12 Mar 2020 15:24:30 +0100 In-Reply-To: <20200312085936.9552-1-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Thu, 12 Mar 2020 11:59:26 +0300") Message-ID: <87y2s5ps69.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Michael Roth , qemu-block@nongnu.org, Paul Durrant , Laszlo Ersek , Christian Schoenebeck , qemu-devel@nongnu.org, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > v9 > 01: A lot of rewordings [thanks to Eric] > Still, keep all r-b marks, assuming that they are mostly about macro = definition > 02: significant changes are: > 1. Do not match double propagation pattern in ERRP_AUTO_PROPAGATE-add= ing rule > 2. Introduce errp->____->errp scheme to match only functions matched = by rule1 > in rules inherited from rule1 > 3. Add rules to warn about unusual patterns > > Also, add line to MAINTAINERS to keep error related coccinelle script= s under > Error section. > 07: add Christian's r-b > 09: add Eric's r-b > 10: a bit of context in xen_block_iothread_create and qmp_object_add() > signature are changed. Patch change is obvious, so I keep Paul's r-b > > v9 is available at > https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-p= artI-v9 Did you forget to push the tag? > v8 is available at > https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-p= artI-v8 [...]