From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D26C35254 for ; Wed, 5 Feb 2020 14:13:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A677121741 for ; Wed, 5 Feb 2020 14:13:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A677121741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 447196E998; Wed, 5 Feb 2020 14:13:03 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id B65F86E998 for ; Wed, 5 Feb 2020 14:13:01 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 06:13:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="220112729" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga007.jf.intel.com with ESMTP; 05 Feb 2020 06:12:59 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 72B635C0D46; Wed, 5 Feb 2020 16:12:06 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <158091171763.3271.18072693037503580803@skylake-alporthouse-com> References: <20200205123757.1834947-1-chris@chris-wilson.co.uk> <871rr9b07x.fsf@gaia.fi.intel.com> <158091171763.3271.18072693037503580803@skylake-alporthouse-com> Date: Wed, 05 Feb 2020 16:12:06 +0200 Message-ID: <87y2th9l8p.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Mark i915.reset as unsigned X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Quoting Mika Kuoppala (2020-02-05 14:03:14) >> Chris Wilson writes: >> >> > We have been using '-1' to mean the maximum i915.reset level in the >> > belief that it was unsigned... This turns out to have been a grave >> > error, and instead of setting the default reset mechanism in igt, >> > we have been disabling reset! >> >> Disabling engine reset? > > Hmm, Right, > > bool intel_has_gpu_reset(const struct intel_gt *gt) > { > if (!i915_modparams.reset) > return NULL; > > return intel_get_gpu_reset(gt); > } > > bool intel_has_reset_engine(const struct intel_gt *gt) > { > if (i915_modparams.reset < 2) > return false; > > return INTEL_INFO(gt->i915)->has_reset_engine; > } > > just engine-reset. Still that wasn't the intention when setting -1. I was trying to correlate the graveness to the code. Glad that we agree. With commit message pointing to per engine reset, Reviewed-by: Mika Kuoppala > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx