From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lsts.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] i915_pm_rps: Be wary if RP0 == RPn
Date: Mon, 27 Jan 2020 11:54:25 +0200 [thread overview]
Message-ID: <87y2ttmdgu.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200124213903.611152-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> If the HW min/max frequencies are the same, there is not much range to
> deal with and a couple of our invalid tests become confused as they are
> actually no-ops.
>
> Error reporting in i915_pm_rps is rudimentary and we deserve better.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1008
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/i915_pm_rps.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c
> index b65eefb03..56c745a5b 100644
> --- a/tests/i915/i915_pm_rps.c
> +++ b/tests/i915/i915_pm_rps.c
> @@ -397,9 +397,11 @@ static void min_max_config(void (*check)(void), bool load_gpu)
> writeval_inval(sysfs_files[MIN].filp, origfreqs[RP0] + 1000);
> check();
>
> - igt_debug("\nDecrease max to RPn (invalid)...\n");
> - writeval_inval(sysfs_files[MAX].filp, origfreqs[RPn]);
> - check();
> + if (origfreqs[RPn] < origfreqs[RP0]) {
> + igt_debug("\nDecrease max to RPn (invalid)...\n");
> + writeval_inval(sysfs_files[MAX].filp, origfreqs[RPn]);
> + check();
> + }
>
> igt_debug("\nDecrease min to midpoint...\n");
> writeval(sysfs_files[MIN].filp, fmid);
> @@ -429,9 +431,11 @@ static void min_max_config(void (*check)(void), bool load_gpu)
> writeval_inval(sysfs_files[MAX].filp, 0);
> check();
>
> - igt_debug("\nIncrease min to RP0 (invalid)...\n");
> - writeval_inval(sysfs_files[MIN].filp, origfreqs[RP0]);
> - check();
> + if (origfreqs[RP0] > origfreqs[RP0]) {
RPn?
-Mika
> + igt_debug("\nIncrease min to RP0 (invalid)...\n");
> + writeval_inval(sysfs_files[MIN].filp, origfreqs[RP0]);
> + check();
> + }
>
> igt_debug("\nIncrease max to midpoint...\n");
> writeval(sysfs_files[MAX].filp, fmid);
> --
> 2.25.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-27 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 21:39 [Intel-gfx] [PATCH i-g-t] i915_pm_rps: Be wary if RP0 == RPn Chris Wilson
2020-01-27 9:54 ` Mika Kuoppala [this message]
2020-01-27 10:01 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ttmdgu.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lsts.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.