From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] SDL_mixer: Add option to prefer Tremor over libvorbis
Date: Thu, 12 Dec 2019 17:14:58 +0100 [thread overview]
Message-ID: <87y2vhh665.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1576166814.3.0@crapouillou.net> (Paul Cercueil's message of "Thu, 12 Dec 2019 17:06:54 +0100")
>>>>> "Paul" == Paul Cercueil <paul@crapouillou.net> writes:
Hi,
>> > +ifeq ($(BR2_PACKAGE_SDL_MIXER_USE_TREMOR),y)
>> > +SDL_MIXER_CONF_OPTS += --enable-music-ogg-tremor
>> > +SDL_MIXER_DEPENDENCIES += tremor
>> > +else
>> > ifeq ($(BR2_PACKAGE_LIBVORBIS),y)
>>
>> Do we need an explicit option for this? Can't we just check for
>> BR2_PACKAGE_TREMOR here? I doubt there is any situations where
>> tremor is
>> enabled but the user doesn't want to use it.
> That's up to you really. I can send a v2 with the Config.in option
> removed.
Yes please - Thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-12-12 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 19:15 [Buildroot] [PATCH 1/2] SDL_mixer: Add option to prefer Tremor over libvorbis Paul Cercueil
2019-12-09 19:15 ` [Buildroot] [PATCH 2/2] SDL_mixer: Add support for libmodplug Paul Cercueil
2019-12-10 9:32 ` Peter Korsgaard
2019-12-10 9:29 ` [Buildroot] [PATCH 1/2] SDL_mixer: Add option to prefer Tremor over libvorbis Peter Korsgaard
2019-12-12 16:06 ` Paul Cercueil
2019-12-12 16:14 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2vhh665.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.