From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Thu, 28 Nov 2019 10:35:29 +0000 Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops Message-Id: <87y2w0mgpa.fsf@intel.com> List-Id: References: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe de Dinechin Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede On Thu, 28 Nov 2019, Christophe de Dinechin wrote: >> On 27 Nov 2019, at 17:32, Jani Nikula wrote: >> >> Now that the fbops member of struct fb_info is const, we can star making > s/star/start/ Ooops, thanks. BR, Jani. > >> the ops const as well. >> >> Cc: Kirti Wankhede >> Cc: kvm@vger.kernel.org >> Signed-off-by: Jani Nikula >> --- >> samples/vfio-mdev/mdpy-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >> index 2719bb259653..21dbf63d6e41 100644 >> --- a/samples/vfio-mdev/mdpy-fb.c >> +++ b/samples/vfio-mdev/mdpy-fb.c >> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >> iounmap(info->screen_base); >> } >> >> -static struct fb_ops mdpy_fb_ops = { >> +static const struct fb_ops mdpy_fb_ops = { >> .owner = THIS_MODULE, >> .fb_destroy = mdpy_fb_destroy, >> .fb_setcolreg = mdpy_fb_setcolreg, >> -- >> 2.20.1 >> > -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops Date: Thu, 28 Nov 2019 12:35:29 +0200 Message-ID: <87y2w0mgpa.fsf@intel.com> References: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christophe de Dinechin Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyOCBOb3YgMjAxOSwgQ2hyaXN0b3BoZSBkZSBEaW5lY2hpbiA8Y2hyaXN0b3BoZS5k ZS5kaW5lY2hpbkBnbWFpbC5jb20+IHdyb3RlOgo+PiBPbiAyNyBOb3YgMjAxOSwgYXQgMTc6MzIs IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+IHdyb3RlOgo+PiAKPj4gTm93IHRo YXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBjb25zdCwgd2UgY2FuIHN0 YXIgbWFraW5nCj4gcy9zdGFyL3N0YXJ0LwoKT29vcHMsIHRoYW5rcy4KCkJSLApKYW5pLgoKPgo+ PiB0aGUgb3BzIGNvbnN0IGFzIHdlbGwuCj4+IAo+PiBDYzogS2lydGkgV2Fua2hlZGUgPGt3YW5r aGVkZUBudmlkaWEuY29tPgo+PiBDYzoga3ZtQHZnZXIua2VybmVsLm9yZwo+PiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gc2FtcGxl cy92ZmlvLW1kZXYvbWRweS1mYi5jIHwgMiArLQo+PiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9zYW1wbGVzL3ZmaW8tbWRl di9tZHB5LWZiLmMgYi9zYW1wbGVzL3ZmaW8tbWRldi9tZHB5LWZiLmMKPj4gaW5kZXggMjcxOWJi MjU5NjUzLi4yMWRiZjYzZDZlNDEgMTAwNjQ0Cj4+IC0tLSBhL3NhbXBsZXMvdmZpby1tZGV2L21k cHktZmIuYwo+PiArKysgYi9zYW1wbGVzL3ZmaW8tbWRldi9tZHB5LWZiLmMKPj4gQEAgLTg2LDcg Kzg2LDcgQEAgc3RhdGljIHZvaWQgbWRweV9mYl9kZXN0cm95KHN0cnVjdCBmYl9pbmZvICppbmZv KQo+PiAJCWlvdW5tYXAoaW5mby0+c2NyZWVuX2Jhc2UpOwo+PiB9Cj4+IAo+PiAtc3RhdGljIHN0 cnVjdCBmYl9vcHMgbWRweV9mYl9vcHMgPSB7Cj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGZiX29w cyBtZHB5X2ZiX29wcyA9IHsKPj4gCS5vd25lcgkJPSBUSElTX01PRFVMRSwKPj4gCS5mYl9kZXN0 cm95CT0gbWRweV9mYl9kZXN0cm95LAo+PiAJLmZiX3NldGNvbHJlZwk9IG1kcHlfZmJfc2V0Y29s cmVnLAo+PiAtLSAKPj4gMi4yMC4xCj4+IAo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA10C432C0 for ; Thu, 28 Nov 2019 10:35:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BAC921775 for ; Thu, 28 Nov 2019 10:35:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BAC921775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB5C06E7A2; Thu, 28 Nov 2019 10:35:37 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97EF16E79D; Thu, 28 Nov 2019 10:35:35 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 02:35:35 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="199487561" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 02:35:32 -0800 From: Jani Nikula To: Christophe de Dinechin Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Date: Thu, 28 Nov 2019 12:35:29 +0200 Message-ID: <87y2w0mgpa.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191128103529.7WoSXhkW7qJ2JN3uDCCtIS0AuI-J-JjQTucaCRkWO3E@z> T24gVGh1LCAyOCBOb3YgMjAxOSwgQ2hyaXN0b3BoZSBkZSBEaW5lY2hpbiA8Y2hyaXN0b3BoZS5k ZS5kaW5lY2hpbkBnbWFpbC5jb20+IHdyb3RlOgo+PiBPbiAyNyBOb3YgMjAxOSwgYXQgMTc6MzIs IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+IHdyb3RlOgo+PiAKPj4gTm93IHRo YXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBjb25zdCwgd2UgY2FuIHN0 YXIgbWFraW5nCj4gcy9zdGFyL3N0YXJ0LwoKT29vcHMsIHRoYW5rcy4KCkJSLApKYW5pLgoKPgo+ PiB0aGUgb3BzIGNvbnN0IGFzIHdlbGwuCj4+IAo+PiBDYzogS2lydGkgV2Fua2hlZGUgPGt3YW5r aGVkZUBudmlkaWEuY29tPgo+PiBDYzoga3ZtQHZnZXIua2VybmVsLm9yZwo+PiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gc2FtcGxl cy92ZmlvLW1kZXYvbWRweS1mYi5jIHwgMiArLQo+PiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9zYW1wbGVzL3ZmaW8tbWRl di9tZHB5LWZiLmMgYi9zYW1wbGVzL3ZmaW8tbWRldi9tZHB5LWZiLmMKPj4gaW5kZXggMjcxOWJi MjU5NjUzLi4yMWRiZjYzZDZlNDEgMTAwNjQ0Cj4+IC0tLSBhL3NhbXBsZXMvdmZpby1tZGV2L21k cHktZmIuYwo+PiArKysgYi9zYW1wbGVzL3ZmaW8tbWRldi9tZHB5LWZiLmMKPj4gQEAgLTg2LDcg Kzg2LDcgQEAgc3RhdGljIHZvaWQgbWRweV9mYl9kZXN0cm95KHN0cnVjdCBmYl9pbmZvICppbmZv KQo+PiAJCWlvdW5tYXAoaW5mby0+c2NyZWVuX2Jhc2UpOwo+PiB9Cj4+IAo+PiAtc3RhdGljIHN0 cnVjdCBmYl9vcHMgbWRweV9mYl9vcHMgPSB7Cj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGZiX29w cyBtZHB5X2ZiX29wcyA9IHsKPj4gCS5vd25lcgkJPSBUSElTX01PRFVMRSwKPj4gCS5mYl9kZXN0 cm95CT0gbWRweV9mYl9kZXN0cm95LAo+PiAJLmZiX3NldGNvbHJlZwk9IG1kcHlfZmJfc2V0Y29s cmVnLAo+PiAtLSAKPj4gMi4yMC4xCj4+IAo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA94C432C0 for ; Thu, 28 Nov 2019 10:35:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD7A421775 for ; Thu, 28 Nov 2019 10:35:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD7A421775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54BF16E79D; Thu, 28 Nov 2019 10:35:37 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97EF16E79D; Thu, 28 Nov 2019 10:35:35 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 02:35:35 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="199487561" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 02:35:32 -0800 From: Jani Nikula To: Christophe de Dinechin In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Date: Thu, 28 Nov 2019 12:35:29 +0200 Message-ID: <87y2w0mgpa.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 13/13] samples: vfio-mdev: constify fb ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191128103529._2B79ROwQZIeTcU1PJVWFW7MmqIq8H2ZFBo2o3T2fjM@z> T24gVGh1LCAyOCBOb3YgMjAxOSwgQ2hyaXN0b3BoZSBkZSBEaW5lY2hpbiA8Y2hyaXN0b3BoZS5k ZS5kaW5lY2hpbkBnbWFpbC5jb20+IHdyb3RlOgo+PiBPbiAyNyBOb3YgMjAxOSwgYXQgMTc6MzIs IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+IHdyb3RlOgo+PiAKPj4gTm93IHRo YXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBjb25zdCwgd2UgY2FuIHN0 YXIgbWFraW5nCj4gcy9zdGFyL3N0YXJ0LwoKT29vcHMsIHRoYW5rcy4KCkJSLApKYW5pLgoKPgo+ PiB0aGUgb3BzIGNvbnN0IGFzIHdlbGwuCj4+IAo+PiBDYzogS2lydGkgV2Fua2hlZGUgPGt3YW5r aGVkZUBudmlkaWEuY29tPgo+PiBDYzoga3ZtQHZnZXIua2VybmVsLm9yZwo+PiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gc2FtcGxl cy92ZmlvLW1kZXYvbWRweS1mYi5jIHwgMiArLQo+PiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9zYW1wbGVzL3ZmaW8tbWRl di9tZHB5LWZiLmMgYi9zYW1wbGVzL3ZmaW8tbWRldi9tZHB5LWZiLmMKPj4gaW5kZXggMjcxOWJi MjU5NjUzLi4yMWRiZjYzZDZlNDEgMTAwNjQ0Cj4+IC0tLSBhL3NhbXBsZXMvdmZpby1tZGV2L21k cHktZmIuYwo+PiArKysgYi9zYW1wbGVzL3ZmaW8tbWRldi9tZHB5LWZiLmMKPj4gQEAgLTg2LDcg Kzg2LDcgQEAgc3RhdGljIHZvaWQgbWRweV9mYl9kZXN0cm95KHN0cnVjdCBmYl9pbmZvICppbmZv KQo+PiAJCWlvdW5tYXAoaW5mby0+c2NyZWVuX2Jhc2UpOwo+PiB9Cj4+IAo+PiAtc3RhdGljIHN0 cnVjdCBmYl9vcHMgbWRweV9mYl9vcHMgPSB7Cj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGZiX29w cyBtZHB5X2ZiX29wcyA9IHsKPj4gCS5vd25lcgkJPSBUSElTX01PRFVMRSwKPj4gCS5mYl9kZXN0 cm95CT0gbWRweV9mYl9kZXN0cm95LAo+PiAJLmZiX3NldGNvbHJlZwk9IG1kcHlfZmJfc2V0Y29s cmVnLAo+PiAtLSAKPj4gMi4yMC4xCj4+IAo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F83BC432C3 for ; Thu, 28 Nov 2019 10:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E17A21781 for ; Thu, 28 Nov 2019 10:35:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbfK1Kff (ORCPT ); Thu, 28 Nov 2019 05:35:35 -0500 Received: from mga14.intel.com ([192.55.52.115]:39823 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfK1Kff (ORCPT ); Thu, 28 Nov 2019 05:35:35 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 02:35:35 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="199487561" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 02:35:32 -0800 From: Jani Nikula To: Christophe de Dinechin Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org, Kirti Wankhede , kvm@vger.kernel.org Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> Date: Thu, 28 Nov 2019 12:35:29 +0200 Message-ID: <87y2w0mgpa.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 28 Nov 2019, Christophe de Dinechin wrote: >> On 27 Nov 2019, at 17:32, Jani Nikula wrote: >> >> Now that the fbops member of struct fb_info is const, we can star making > s/star/start/ Ooops, thanks. BR, Jani. > >> the ops const as well. >> >> Cc: Kirti Wankhede >> Cc: kvm@vger.kernel.org >> Signed-off-by: Jani Nikula >> --- >> samples/vfio-mdev/mdpy-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >> index 2719bb259653..21dbf63d6e41 100644 >> --- a/samples/vfio-mdev/mdpy-fb.c >> +++ b/samples/vfio-mdev/mdpy-fb.c >> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >> iounmap(info->screen_base); >> } >> >> -static struct fb_ops mdpy_fb_ops = { >> +static const struct fb_ops mdpy_fb_ops = { >> .owner = THIS_MODULE, >> .fb_destroy = mdpy_fb_destroy, >> .fb_setcolreg = mdpy_fb_setcolreg, >> -- >> 2.20.1 >> > -- Jani Nikula, Intel Open Source Graphics Center