From: Kalle Valo <kvalo@codeaurora.org>
To: zhengbin <zhengbin13@huawei.com>
Cc: <stas.yakovlev@gmail.com>, <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason'
Date: Sat, 16 Nov 2019 09:51:25 +0200 [thread overview]
Message-ID: <87y2wguuma.fsf@codeaurora.org> (raw)
In-Reply-To: <1573890083-33761-2-git-send-email-zhengbin13@huawei.com> (zhengbin's message of "Sat, 16 Nov 2019 15:41:22 +0800")
zhengbin <zhengbin13@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function ipw_wx_set_mlme:
> drivers/net/wireless/intel/ipw2x00/ipw2200.c:6805:9: warning: variable reason set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 367a1092b555 ("ipw2x00:
> move under intel vendor directory"), but never used, so remove it.
No it's not, as the commit title says it's only moving files to a
different location. I'll remove that sentence from the commit log.
--
Kalle Valo
next prev parent reply other threads:[~2019-11-16 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 7:41 [PATCH -next 0/2] ipw2x00: remove some set but not used variables zhengbin
2019-11-16 7:41 ` [PATCH -next 1/2] ipw2x00: remove set but not used variable 'reason' zhengbin
2019-11-16 7:51 ` Kalle Valo [this message]
2019-11-20 7:34 ` Kalle Valo
2019-11-16 7:41 ` [PATCH -next 2/2] ipw2x00: remove set but not used variable 'force_update' zhengbin
2019-11-16 7:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2wguuma.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.