From: Jani Nikula <jani.nikula@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vbt: Child device size remains unchanged through VBT 229
Date: Mon, 07 Oct 2019 14:33:51 +0300 [thread overview]
Message-ID: <87y2xwhjs0.fsf@intel.com> (raw)
In-Reply-To: <20191002192258.1013-1-matthew.d.roper@intel.com>
On Wed, 02 Oct 2019, Matt Roper <matthew.d.roper@intel.com> wrote:
> The latest documented version of the VBT is 229, but no further data has
> been added to the child device definition in block 2. Update the child
> device version test to eliminate the "Expected child device config size
> for VBT version XXX not known; assuming 39" debug messages from the
> logs.
>
> Bspec: 20124
> Bspec: 20157
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 1def550c68c8..9628b485b179 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1615,7 +1615,7 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> expected_size = 37;
> } else if (bdb->version <= 215) {
> expected_size = 38;
> - } else if (bdb->version <= 216) {
> + } else if (bdb->version <= 229) {
> expected_size = 39;
> } else {
> expected_size = sizeof(*child);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-10-07 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 19:22 [PATCH] drm/i915/vbt: Child device size remains unchanged through VBT 229 Matt Roper
2019-10-02 23:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-03 9:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-07 17:25 ` Matt Roper
2019-10-07 11:33 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2xwhjs0.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.