From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v6 3/5] drm/i915/gen11: Convert combo PHY logic to use new 'enum phy' namespace Date: Wed, 04 Sep 2019 19:47:39 +0300 Message-ID: <87y2z4vwic.fsf@intel.com> References: <20190709183934.445-1-matthew.d.roper@intel.com> <20190709183934.445-4-matthew.d.roper@intel.com> <875zm841pi.fsf@intel.com> <20190904145726.GO13677@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8B9D89C6A for ; Wed, 4 Sep 2019 16:46:50 +0000 (UTC) In-Reply-To: <20190904145726.GO13677@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAwNCBTZXAgMjAxOSwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNv bT4gd3JvdGU6Cj4gT24gV2VkLCBTZXAgMDQsIDIwMTkgYXQgMDQ6NDI6NDlQTSArMDMwMCwgSmFu aSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFR1ZSwgMDkgSnVsIDIwMTksIE1hdHQgUm9wZXIgPG1hdHRo ZXcuZC5yb3BlckBpbnRlbC5jb20+IHdyb3RlOgo+PiA+IENvbnZlcnQgdGhlIGNvZGUgdGhhdCBv cGVyYXRlcyBkaXJlY3RseSBvbiBnZW4xMSBjb21ibyBQSFkncyB0byB1c2UgdGhlCj4+ID4gbmV3 IG5hbWVzcGFjZS4gIENvbWJvIFBIWSByZWdpc3RlcnMgYXJlIHRob3NlIG5hbWVkICJJQ0xfUE9S VF8qIiBwbHVzCj4+ID4gSUNMX0RQSFlfQ0hLTi4KPj4gPgo+PiA+IE5vdGUgdGhhdCBhIGxvdCBv ZiB0aGUgUEhZIHByb2dyYW1taW5nIGhhcHBlbnMgaW4gdGhlIE1JUEkgRFNJIGNvZGUuCj4+ID4g Rm9yIGNsYXJpdHkgSSd2ZSBhZGRlZCBhIGZvcl9lYWNoX2RzaV9waHkoKSB0byBsb29wIG92ZXIg dGhlIHBoeXMgdXNlZAo+PiA+IGJ5IERTSS4gIFNpbmNlIERTSSBhbHdheXMgdXNlcyBBICYgQiBv biBnZW4xMSwgcG9ydD1waHkgaW4gYWxsIGNhc2VzIHNvCj4+ID4gaXQgZG9lc24ndCBhY3R1YWxs eSBtYXR0ZXIgd2hpY2ggZm9ybSB3ZSB1c2UgaW4gdGhlIERTSSBjb2RlLiAgSSd2ZSB1c2VkCj4+ ID4gdGhlIHBoeSBpdGVyYXRvciBpbiBjb2RlIHRoYXQncyBleHBsaWNpdGx5IHdvcmtpbmcgd2l0 aCB0aGUgY29tYm8gUEhZLAo+PiA+IGJ1dCBsZWZ0IHRoZSByZXN0IG9mIHRoZSBEU0kgY29kZSB1 c2luZyB0aGUgcG9ydCBpdGVyYXRvciBhbmQgbmFtZXNwYWNlCj4+ID4gdG8gbWluaW1pemUgcGF0 Y2ggZGVsdGFzLiAgV2UgY2FuIHN3aXRjaCB0aGUgcmVzdCBvZiB0aGUgRFNJIGNvZGUgb3Zlcgo+ PiA+IHRvIHVzZSBwaHkgdGVybWlub2xvZ3kgbGF0ZXIgaWYgdGhpcyB3aW5kcyB1cCBiZWluZyB0 b28gY29uZnVzaW5nLgo+PiAKPj4gT25lIGl0c3ktYml0c3kgZGV0YWlsLCB3aGVyZSBkb2VzIHRo aXMgaW5pdGlhbGl6ZSBpbnRlbF9kc2ktPnBoeXM/Cj4+IExvb2tpbmcgYXQgdGhlIGNvZGUsIEkn bSB0aGlua2luZyBub3doZXJlLgo+Cj4gQXQgdGhlIG1vbWVudCB3ZSdyZSByZWx5aW5nIG9uIHRo ZSBmYWN0IHRoYXQgcG9ydD09cGh5IGFsd2F5cyBmb3IgRFNJIG9uCj4gdGhlIHBsYXRmb3JtcyB0 aGlzIGNvZGUgYXBwbGllcyB0by4gIGludGVsX2RzaS0+cG9ydHMgaXMgaW5pdGlhbGl6ZWQKPgo+ ICAgICAgICAgaWYgKGRldl9wcml2LT52YnQuZHNpLmNvbmZpZy0+ZHVhbF9saW5rKQo+ICAgICAg ICAgICAgICAgICBpbnRlbF9kc2ktPnBvcnRzID0gQklUKFBPUlRfQSkgfCBCSVQoUE9SVF9CKTsK PiAgICAgICAgIGVsc2UKPiAgICAgICAgICAgICAgICAgaW50ZWxfZHNpLT5wb3J0cyA9IEJJVChw b3J0KTsKPgo+IGFuZCB0aGF0J3MgdW5pb25lZCB3aXRoIGludGVsX2RzaS0+cGh5cwo+Cj4gICAg ICAgICAvKiBiaXQgbWFzayBvZiBwb3J0cyAodmx2IGRzaSkgb3IgcGh5cyAoaWNsIGRzaSkgYmVp bmcgZHJpdmVuICovCj4gICAgICAgICB1bmlvbiB7Cj4gICAgICAgICAgICAgICAgIHUxNiBwb3J0 czsgICAgICAvKiBWTFYgRFNJICovCj4gICAgICAgICAgICAgICAgIHUxNiBwaHlzOyAgICAgICAv KiBJQ0wgRFNJICovCj4gICAgICAgICB9Owo+Cj4gc28gSSB0aGluayB0aGUgaW5pdGlhbGl6YXRp b24gc2hvdWxkIGJlIHRoZSBzYW1lIGFzIGl0IHdhcyBiZWZvcmUgdGhpcyBwYXRjaC4KClJpZ2h0 LCB0aGUgdW5pb24gaXMgd2hhdCBJIG1pc3NlZCBjb21wbGV0ZWx5LiBJIHdhcyBsb29raW5nIGZv ciAtPnBoeXMKaW5pdGlhbGl6YXRpb24gYnV0IGNvdWxkbid0IGZpbmQgaXQuIFNvcnJ5IGZvciB0 aGUgbm9pc2UhCgo+IEFzIEkgbWVudGlvbmVkIGFib3ZlLCB0aGlzIHBhdGNoIG9ubHkgY2hhbmdl cyB0aGUgaW5zdGFuY2VzIG9mICdlbnVtIHBvcnQnIHRvCj4gJ2VudW0gcGh5JyB3aGVyZSB0aGV5 IHdlcmUgc3BlY2lmaWNhbGx5IHRvdWNoaW5nIHRoZSBjb21ibyBQSFkgcmVnaXN0ZXJzLCBhbmQK PiBsZWZ0IGEgYnVuY2ggb2YgdGhlIG90aGVyIGNvZGUgdXNpbmcgJ2VudW0gcG9ydCcgdG8gbWlu aW1pemUgdGhlIGluaXRpYWwgY29kZQo+IGRpZmZzLiAgSXQncyBwcm9iYWJseSB0aW1lIG5vdyB0 byBmb2xsb3cgdXAgd2l0aCBhbm90aGVyIHBhdGNoIHRoYXQgY29udmVydHMKPiB0aGUgcmVzdCBv ZiB0aGUgZmlsZSB0byBwaHkgdXNhZ2UgdG8gYXZvaWQgY29uZnVzaW9uOyBJJ2xsIHdyaXRlIGEg cGF0Y2ggdG8gZG8KPiB0aGF0IGxhdGVyIHRvZGF5IG9yIHRvbW9ycm93LgoKRG8geW91IHByb3Bv c2UgdG8gaW5kZXggdGhlIHJlc3Qgb2YgdGhlIHJlbGV2YW50IHJlZ2lzdGVycyB3aXRoIHBoeSB0 b28/CihJIGtub3cgdGhlcmUncyBubyBlZmZlY3RpdmUgY2hhbmdlLCBqdXN0IHRoZSBuYW1lLikg U2hvdWxkIHdlIGNoYW5nZQpkc2lfcG9ydF90b190cmFuc2NvZGVyKCkgdG8gZHNpX3BoeV90b190 cmFuc2NvZGVyKCk/CgpJbiBhbnkgY2FzZSBJIGFncmVlIHNvbWUgZGUtY29uZnVzaW5nIHdvdWxk IGJlIGluIG9yZGVyLgoKPj4gV2UgaGF2ZSBhbiBJQ0wgRFNJIG1hY2hpbmUgaW4gQ0ksIHdoaWNo IHJlcG9ydHMgYWxsIGdyZWVuIG9uIHRoaXMKPj4gcGF0Y2guLi4gYnV0IG1vc3QgbGlrZWx5IHRo ZSBkaXNwbGF5IGlzIGFsbCBibGFjayBpbnN0ZWFkLiBEU0kgYmVpbmcKPj4gRFNJLCBpdCBpcyBl bnRpcmVseSBwb3NzaWJsZSB3ZSBoYXZlIG5vIHdheSBvZiBrbm93aW5nIHdpdGhvdXQgaGF2aW5n IGEKPj4gY2FtZXJhIGNhcHR1cmUgdGhlIGRpc3BsYXkuCj4KPiBIbW0uICBBbGwgZ3JlZW4gYWxs IHRoZSB0aW1lIG9yIG9ubHkgb24gc3BlY2lmaWMgdGVzdHMvb3BlcmF0aW9ucz8gIEkgYXNzdW1l Cj4gdGhpcyBpcyBodHRwczovL2ludGVsLWdmeC1jaS4wMS5vcmcvaGFyZHdhcmUvZmktaWNsLWRz aS8gPyAgU3RyYW5nZWx5IEkgZG9uJ3QKPiBzZWUgYW4gaTkxNV9kaXNwbGF5X2luZm8gZm9yIHRo YXQgbWFjaGluZSwgYnV0IHRoZSBjdXJyZW50IENJIHJlc3VsdHMgc2VlbSB0bwo+IGJlIG1vc3Rs eSBwYXNzaW5nLiAgSXMgdGhlcmUgYSBzcGVjaWZpYyBmYWlsaW5nIHRlc3QgSSBzaG91bGQgbG9v ayBhdD8KClRoaXMgd2FzIGFsbCBiYXNlZCBvbiBtZSBmYWlsaW5nIHRvIGZpbmQgdGhlIC0+cGh5 cyBpbml0aWFsaXphdGlvbjsgSQp0aGluayBpdCdzIGNvbmNlaXZhYmxlIHdlIHdvdWxkbid0IGhh dmUgcmVjZWl2ZWQgYW55IGRyaXZlciBkZXRlY3RhYmxlCmVycm9ycyBldmVuIGlmIC0+cGh5cyB3 ZXJlIHplcm8uIEp1c3QgYSBibGFjayBzY3JlZW4uIEJ1dCBhZ2Fpbiwgc29ycnkKZm9yIHRoZSBu b2lzZSEKCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdy YXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n Zng=