All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: drm/i915: always split up refactoring from functional changes!
Date: Wed, 07 Aug 2019 13:15:53 +0300	[thread overview]
Message-ID: <87y305i8me.fsf@intel.com> (raw)
In-Reply-To: <20190806164713.GA25907@intel.com>

On Tue, 06 Aug 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Tue, Aug 06, 2019 at 03:22:07PM +0300, Jani Nikula wrote:
>> 
>> Rodrigo's original patch was at v5 [1], and still stuck in discussion
>> around the *functional* change, while 99% of the patch is
>> *non-functional* refactoring that does not seem to be contentious.
>> 
>> Let's do the sane thing and merge the refactoring first, shall we?
>
> Makes sense. Thanks a lot for taking care of that.

And pushed. Thanks for the patch. ;)

BR,
Jani.


>
>> 
>> BR,
>> Jani.
>> 
>> 
>> [1] http://patchwork.freedesktop.org/patch/msgid/20190718204912.24149-1-rodrigo.vivi@intel.com
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-07 10:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 12:22 drm/i915: always split up refactoring from functional changes! Jani Nikula
2019-08-06 12:22 ` [PATCH] drm/i915: abstract display suspend/resume operations Jani Nikula
2019-08-06 13:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-06 16:47 ` drm/i915: always split up refactoring from functional changes! Rodrigo Vivi
2019-08-07 10:15   ` Jani Nikula [this message]
2019-08-06 22:34 ` ✓ Fi.CI.IGT: success for drm/i915: abstract display suspend/resume operations Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y305i8me.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.